r58401 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58400‎ | r58401 | r58402 >
Date:13:58, 1 November 2009
Author:demon
Status:ok
Tags:
Comment:
Fix another regression from r57558, bug 21369 - Lowercase logins causes MediaWiki to crash
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -693,8 +693,9 @@
694694 * - 'creatable' Valid for batch processes, login and account creation
695695 */
696696 static function getCanonicalName( $name, $validate = 'valid' ) {
697 - # Maybe force usernames to capital
698 - $name = Title::capitalize( $name, NS_USER );
 697+ # Force usernames to capital
 698+ global $wgContLang;
 699+ $name = $wgContLang->ucfirst( $name );
699700
700701 # Reject names containing '#'; these will be cleaned up
701702 # with title normalisation, but then it's too late to

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57558(bug 13750) $wgCapitalLinks should be a per-namespace settingdemon12:52, 9 October 2009

Status & tagging log