r58354 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r58353‎ | r58354 | r58355 >
Date:07:27, 30 October 2009
Author:siebrand
Status:deferred (Comments)
Tags:
Comment:
Follow-up r58353: Use $wgExtensionAliasesFiles for special page aliases
Modified paths:
  • /trunk/extensions/Wikilog/Wikilog.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikilog/Wikilog.php
——@@ -51,7 +51,7 @@
5252 $dir = dirname( __FILE__ ) . '/';
5353 $wgExtensionMessagesFiles['Wikilog'] = $dir . 'Wikilog.i18n.php';
5454 $wgExtensionMessagesFiles['WikilogMagic'] = $dir . 'Wikilog.i18n.magic.php';
55 -$wgExtensionMessagesFiles['WikilogAlias'] = $dir . 'Wikilog.i18n.alias.php';
 55+$wgExtensionAliasesFiles['WikilogAlias'] = $dir . 'Wikilog.i18n.alias.php';
5656
5757 /*
5858 * Autoloaded classes.

Follow-up revisions

RevisionCommit summaryAuthorDate
r58367Revert r58354, since $wgExtensionAliasesFiles is deprecated with the new...juliano17:49, 30 October 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r58353Update localisation for compatibility with Mw 1.16 LocalisationCache.juliano02:38, 30 October 2009

Comments

#Comment by Juliano (talk | contribs)   13:15, 30 October 2009

This is confusing... includes/DefaultSettings.php lists $wgExtensionAliasesFiles as deprecated in favor of $wgExtensionMessagesFiles...

#Comment by Siebrand (talk | contribs)   14:15, 30 October 2009

It is!? Reading the Friendly Source (because I haven't used it for special page aliases yet, and think/thought that was not possible...)

5 minutes later...

Ouch, you are right. Lemme quote the source for posterity and note that this should be changed in the repo after the 1.16 branching. My apologies for confusing you. I honestly thought it was wrong, and I hadn't seen its use yet for special page aliases. 

/**
 * Extension messages files.
 *
 * Associative array mapping extension name to the filename where messages can be
 * found. The file should contain variable assignments. Any of the variables
 * present in languages/messages/MessagesEn.php may be defined, but $messages
 * is the most common.
 *
 * Variables defined in extensions will override conflicting variables defined
 * in the core.
 *
 * Example:
 *    $wgExtensionMessagesFiles['ConfirmEdit'] = dirname(__FILE__).'/ConfirmEdit.i18n.php';
 *
 */
$wgExtensionMessagesFiles = array();

/**
 * Aliases for special pages provided by extensions.
 * @deprecated Use $specialPageAliases in a file referred to by $wgExtensionMessagesFiles
 */
$wgExtensionAliasesFiles = array();
#Comment by Juliano (talk | contribs)   17:42, 30 October 2009

Heh, Ok! I'm going to revert it then. No problem :-)

Status & tagging log