r58286 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r58285‎ | r58286 | r58287 >
Date:21:29, 28 October 2009
Author:adam
Status:resolved (Comments)
Tags:
Comment:
adding styles for the collapsible toc
Modified paths:
  • /trunk/extensions/UsabilityInitiative/css/wikiEditor.tocCollapse.css (added) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/css/wikiEditor.tocCollapse.css
——@@ -0,0 +1,20 @@
 2+/* Collapsing changes */
 3+.wikiEditor-ui-toc ul{
 4+ width:132px;
 5+ float:left;
 6+}
 7+.wikiEditor-ui-toc ul ul{
 8+ width:auto;
 9+}
 10+#wikiEditor-ui-toc-colapse{
 11+ height:100%;
 12+ width:18px;
 13+ float:left;
 14+}
 15+.wikiEditor-ui-toc-collapse-open{
 16+ background:#f3f3f3 url(../images/wikiEditor/toc/close.png) 4px 50% no-repeat;
 17+ border-left:1px solid #DDDDDD;
 18+}
 19+.wikiEditor-ui-toc-collapse-closed{
 20+ background:#f3f3f3 url(../images/wikiEditor/toc/open.png) 4px 50% no-repeat;
 21+}
\ No newline at end of file

Comments

#Comment by Catrope (talk | contribs)   21:37, 28 October 2009
  • It's possible to add multiple files and dirs in one commit (re r58287, r58288)
  • You've misspelled #wikiEditor-ui-toc-colapse
  • I see no reason to put this in a separate plugin; wouldn't it be easier to put this code in the TOC plugin and add a var so it can be disabled?
#Comment by Adammiller~mediawikiwiki (talk | contribs)   14:05, 29 October 2009

Can you link me to an example of adding and committing multiple individual files? I had other local changes I didn't want to commit but I wasn't sure how else to do it with svn. I'm spoiled by git.

I wanted this in svn so I could grab it at home today and keep working on it. I tried to put it somewhere you and Trevor would complain the least about it, since it's a rough first pass at this functionality.

Lo siento.

#Comment by Catrope (talk | contribs)   14:37, 29 October 2009

Just do: 

$ cd mediawiki/trunk/extensions/UsabilityInitiative
$ svn add file1
A file1
$ svn add dir1
A dir1/
A dir1/file1
A dir1/file2
$ svn commit

Status & tagging log