r58206 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58205‎ | r58206 | r58207 >
Date:19:03, 27 October 2009
Author:raymond
Status:ok
Tags:
Comment:
Allow nicer links: Special:GlobalBlockList/1.2.3.4
Modified paths:
  • /trunk/extensions/GlobalBlocking/SpecialGlobalBlockList.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GlobalBlocking/SpecialGlobalBlockList.php
@@ -12,7 +12,8 @@
1313 global $wgUser,$wgOut,$wgRequest;
1414
1515 $this->setHeaders();
16 - $this->loadParameters();
 16+ $ip = isset( $par ) ? $par : $wgRequest->getText( 'ip' );
 17+ $this->loadParameters( $ip );
1718
1819 $wgOut->setPageTitle( wfMsg( 'globalblocking-list' ) );
1920 $wgOut->setRobotPolicy( "noindex,nofollow" );
@@ -113,9 +114,9 @@
114115 }
115116 }
116117
117 - function loadParameters() {
118 - global $wgRequest,$wgUser;
119 - $this->mSearchIP = Block::normaliseRange( trim($wgRequest->getText( 'ip' )) );
 118+ function loadParameters( $ip ) {
 119+ global $wgUser;
 120+ $this->mSearchIP = Block::normaliseRange( trim( $ip ) );
120121 }
121122 }
122123

Follow-up revisions

RevisionCommit summaryAuthorDate
r58207Follow-up r58193: Make the link nicer (related to r58206)raymond19:09, 27 October 2009

Status & tagging log