r58197 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r58196‎ | r58197 | r58198 >
Date:15:19, 27 October 2009
Author:freakolowsky
Status:ok
Tags:
Comment:
removed ts_tags from getQueryInfo. it's already added in ChangeTags::modifyDisplayQuery. Causes column abigious definition error in Oracle
Modified paths:
  • /trunk/phase3/includes/HistoryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HistoryPage.php
——@@ -319,7 +319,7 @@
320320 function getQueryInfo() {
321321 $queryInfo = array(
322322 'tables' => array('revision'),
323 - 'fields' => array_merge( Revision::selectFields(), array('ts_tags') ),
 323+ 'fields' => array_merge( Revision::selectFields()),
324324 'conds' => array_merge( array('rev_page' => $this->historyPage->title->getArticleID() ), $this->conds ),
325325 'options' => array( 'USE INDEX' => array('revision' => 'page_timestamp') ),
326326 'join_conds' => array( 'tag_summary' => array( 'LEFT JOIN', 'ts_rev_id=rev_id' ) ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r60491Fix for r58197, removed unnecessary array_merge()tstarling08:01, 30 December 2009

Status & tagging log