r58049 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58048‎ | r58049 | r58050 >
Date:09:37, 23 October 2009
Author:midom
Status:ok (Comments)
Tags:
Comment:
fix regression introduced by r54225 - special page skipping was ignored by maintenance scripts
Modified paths:
  • /branches/wmf-deployment/maintenance/updateSpecialPages.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/maintenance/updateSpecialPages.php
@@ -32,7 +32,7 @@
3333 }
3434
3535 public function execute() {
36 - global $IP, $wgOut, $wgSpecialPageCacheUpdates, $wgQueryPages, $wgQueryCacheLimit;
 36+ global $IP, $wgOut, $wgSpecialPageCacheUpdates, $wgQueryPages, $wgQueryCacheLimit, $wgDisableQueryPageUpdate;
3737 $wgOut->disable();
3838 $dbw = wfGetDB( DB_MASTER );
3939
@@ -72,7 +72,7 @@
7373 continue;
7474 }
7575
76 - if ( $this->hasOption('override') && $wgDisableQueryPageUpdate && in_array( $special, $wgDisableQueryPageUpdate ) ) {
 76+ if ( !$this->hasOption('override') && $wgDisableQueryPageUpdate && in_array( $special, $wgDisableQueryPageUpdate ) ) {
7777 $this->output( sprintf( "%-30s disabled\n", $special ) );
7878 continue;
7979 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54225Merge maintenance-work branch (now with less errors!):...demon19:35, 2 August 2009

Comments

#Comment by Tim Starling (talk | contribs)   07:17, 17 December 2009

Merged to trunk in r58050.

Status & tagging log