r58039 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58038‎ | r58039 | r58040 >
Date:22:01, 22 October 2009
Author:demon
Status:resolved (Comments)
Tags:
Comment:
Fix retarded mistake in 57997, move break to within the if block or it defeats the entire purpose
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -3285,9 +3285,9 @@
32863286 if ( $this->mOptions->getUseTeX() ) {
32873287 $output = $wgContLang->armourMath(
32883288 MathRenderer::renderMath( $content, $attributes ) );
 3289+ break;
32893290 }
32903291 /* else let a tag hook handle it (bug 21222) */
3291 - break;
32923292 case 'gallery':
32933293 $output = $this->renderImageGallery( $content, $attributes );
32943294 break;

Follow-up revisions

RevisionCommit summaryAuthorDate
r58040Fix r57997 and r58039 for realz this timedemon22:07, 22 October 2009

Comments

#Comment by 😂 (talk | contribs)   22:02, 22 October 2009

Blah, r57997 so it links.

#Comment by Platonides (talk | contribs)   22:03, 22 October 2009

That's still wrong. You need to move math below gallery, so the next case is default.

#Comment by 😂 (talk | contribs)   22:07, 22 October 2009

Yeah yeah...

Status & tagging log