r58036 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58035‎ | r58036 | r58037 >
Date:20:00, 22 October 2009
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Fix for r58035: PLURAL needs wfMsgExt with 'parsemag' option
'activeusers-summary' is still a valid message.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialActiveusers.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialActiveusers.php
@@ -139,14 +139,14 @@
140140 global $wgOut, $wgLang, $wgRCMaxAge;
141141
142142 $this->setHeaders();
143 -
 143+
144144 $up = new ActiveUsersPager();
145145
146146 # getBody() first to check, if empty
147147 $usersbody = $up->getBody();
148148
149149 $s = Html::rawElement( 'div', array( 'class' => 'mw-activeusers-intro' ),
150 - wfMsg( 'activeusers-intro', $wgLang->formatNum( ceil( $wgRCMaxAge / 86400 ) ) )
 150+ wfMsgExt( 'activeusers-intro', 'parsemag', $wgLang->formatNum( ceil( $wgRCMaxAge / 86400 ) ) )
151151 );
152152
153153 $s .= $up->getPageHeader();
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2533,7 +2533,7 @@
25342534
25352535 # Special:ActiveUsers
25362536 'activeusers' => 'Active users list',
2537 -#'activeusers-summary' => '', # do not translate or duplicate this message to other languages
 2537+'activeusers-summary' => '', # do not translate or duplicate this message to other languages
25382538 'activeusers-intro' => 'This is a list of users who had some kind of activity within the last $1 {{PLURAL:$1|day|days}}.',
25392539 'activeusers-count' => '$1 {{PLURAL:$1|edit|edits}} in the last {{PLURAL:$3|day|$3 days}}',
25402540 'activeusers-from' => 'Display users starting at:',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r58035* (bug 19319) Add activeusers-intro message at top of SpecialActiveUsers pageaude19:38, 22 October 2009

Comments

#Comment by Nikerabbit (talk | contribs)   05:05, 23 October 2009

New unescaped html messages are discouraged.

Status & tagging log