r58023 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r58022‎ | r58023 | r58024 >
Date:16:48, 22 October 2009
Author:freakolowsky
Status:reverted (Comments)
Tags:
Comment:
Added default value for gender and editfont to avoid Global default invalid message.
Modified paths:
  • /trunk/phase3/includes/Preferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Preferences.php
——@@ -198,6 +198,7 @@
199199 $defaultPreferences['gender'] =
200200 array(
201201 'type' => 'select',
 202+ 'default' => 'male',
202203 'section' => 'personal/info',
203204 'options' => array(
204205 wfMsg( 'gender-male' ) => 'male',
——@@ -660,6 +661,7 @@
661662 $defaultPreferences['editfont'] =
662663 array(
663664 'type' => 'select',
 665+ 'default' => 'default',
664666 'section' => 'editing/advancedediting',
665667 'label-message' => 'editfont-style',
666668 'options' => array(

Comments

#Comment by Raymond (talk | contribs)   17:09, 22 October 2009

gender default changed to "unknown" in r58027.

#Comment by Nikerabbit (talk | contribs)   17:37, 22 October 2009

It is wrong anyway: 

*       'default'  -- default value when the form is displayed

Now it is always shown as unknown instead of the correct value.

#Comment by Freakolowsky (talk | contribs)   08:25, 23 October 2009

reverted in 58048

Status & tagging log