r57589 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57588‎ | r57589 | r57590 >
Date:20:59, 9 October 2009
Author:werdna
Status:ok (Comments)
Tags:
Comment:
Pro tip: when copying code from other classes, replace self:: with ClassName:: (or at least test the code)
Modified paths:
  • /branches/wmf-deployment/includes/ChangesList.php (modified) (history)
  • /branches/wmf-deployment/includes/Revision.php (modified) (history)

Diff [purge]

Property changes on: branches/wmf-deployment/includes/Revision.php
___________________________________________________________________
Name: svn:mergeinfo
11 + /branches/REL1_15/phase3/includes/Revision.php:51646
/branches/wmf-deployment/includes/Revision.php:53381
/trunk/phase3/includes/Revision.php:56213,56215-56216,56218,56334-56336,56338,56340,56343,56345,56347,56350,57154-57447,57530
Index: branches/wmf-deployment/includes/ChangesList.php
@@ -449,9 +449,9 @@
450450 if( $rc->mAttribs['rc_deleted'] & $field ) {
451451 global $wgUser;
452452 $permission = '';
453 - if ( $rc->mAttribs['rc_deleted'] & self::DELETED_RESTRICTED ) {
 453+ if ( $rc->mAttribs['rc_deleted'] & Revision::DELETED_RESTRICTED ) {
454454 $permission = 'suppressrevision';
455 - } elseif ( $field & self::DELETED_TEXT ) {
 455+ } elseif ( $field & Revision::DELETED_TEXT ) {
456456 $permission = 'deletedtext';
457457 } else {
458458 $permission = 'deletedhistory';

Comments

#Comment by Tim Starling (talk | contribs)   03:03, 24 March 2010

Trunk equivalent is r57594.

Status & tagging log