r57568 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57567‎ | r57568 | r57569 >
Date:16:27, 9 October 2009
Author:simetrical
Status:ok (Comments)
Tags:
Comment:
Fix error message for libxml bug from r54828

libxml2 2.7.2 is buggy, only 2.7.3 is fixed. Thanks to Rgoodermote on
IRC for reporting the problem.
Modified paths:
  • /trunk/phase3/maintenance/install-utils.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/install-utils.inc
@@ -38,7 +38,7 @@
3939 if( !$test->ok ) {
4040 echo "Your system has a combination of PHP and libxml2 versions which is buggy\n" .
4141 "and can cause hidden data corruption in MediaWiki and other web apps.\n" .
42 - "Upgrade to PHP 5.2.9 or later and libxml2 2.7.2 or later!\n" .
 42+ "Upgrade to PHP 5.2.9 or later and libxml2 2.7.3 or later!\n" .
4343 "ABORTING (http://bugs.php.net/bug.php?id=45996 for details).\n";
4444 die( -1 );
4545 }
@@ -193,4 +193,4 @@
194194 && is_callable( 'dl' )
195195 && wfIniGetBool( 'enable_dl' )
196196 && !wfIniGetBool( 'safe_mode' );
197 -}
\ No newline at end of file
 197+}

Follow-up revisions

RevisionCommit summaryAuthorDate
r57570Backport r57568: Fix error message for libxml bug from r54828...simetrical16:38, 9 October 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54828Add an install/update-time test for the PHP+libxml2 horrible XML input corrup...brion23:23, 11 August 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   16:52, 9 October 2009

Woops, thanks for the catch!

Status & tagging log