| Index: branches/wmf-deployment/extensions/OggHandler/OggHandler_body.php |
| — | — | @@ -242,7 +242,7 @@ |
| 243 | 243 | ' -n ' . wfEscapeShellArg( $dstPath ) . ' ' . |
| 244 | 244 | ' ' . wfEscapeShellArg( $file->getPath() ) . ' 2>&1'; |
| 245 | 245 | $returnText = wfShellExec( $cmd, $retval ); |
| 246 | | - if ( !$this->removeBadFile( $dstPath, $retval ) || $retval ) { |
| | 246 | + if ( ! $this->removeBadFile( $dstPath, $retval ) ) { |
| 247 | 247 | return new OggVideoDisplay( $file, $file->getURL(), $dstUrl, $width, $height, $length, $dstPath ); |
| 248 | 248 | } |
| 249 | 249 | } |