r57417 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57416‎ | r57417 | r57418 >
Date:07:15, 6 October 2009
Author:siebrand
Status:deferred
Tags:
Comment:
Easier to read checks and fix a logic issue in Continent display
Modified paths:
  • /trunk/extensions/Translate/scripts/groupStatistics.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/scripts/groupStatistics.php
@@ -224,8 +224,7 @@
225225 }
226226 $out->element( 'Code', true );
227227 $out->element( ( $l10n ? "{{int:translate-page-language}}" : 'Language' ), true );
228 -if( ( $options['output'] == 'wiki' || $options['output'] == 'default' ) &&
229 - isset( $options['continent'] ) ) {
 228+if( isset( $options['continent'] ) ) {
230229 $out->element( ( $l10n ? "{{int:translate-gs-continent}}" : 'Continent' ), true );
231230 }
232231
@@ -361,14 +360,13 @@
362361 }
363362
364363 // Fill continent field
365 - if( ( $options['output'] == 'wiki' || $options['output'] == 'default' ) &&
366 - isset( $options['continent'] ) ) {
 364+ if( ( isset( $options['continent'] ) ) {
367365 if( $mostSpokenLanguages[$code][2] == 'multiple' ) {
368366 $continent = ( $l10n ? "{{int:translate-gs-multiple}}" : 'Multiple' );
369367 } else {
370368 $continent = $l10n ?
371 - ucfirst ( $mostSpokenLanguages[$code][2] ) :
372 - "{{int:timezoneregion-" . $mostSpokenLanguages[$code][2] . "}}";
 369+ "{{int:timezoneregion-" . $mostSpokenLanguages[$code][2] . "}}" :
 370+ ucfirst ( $mostSpokenLanguages[$code][2] );
373371 }
374372
375373 $out->element( $continent );

Follow-up revisions

RevisionCommit summaryAuthorDate
r57418Fix syntax error in r57417siebrand07:16, 6 October 2009

Status & tagging log