r57335 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57334‎ | r57335 | r57336 >
Date:18:18, 3 October 2009
Author:siebrand
Status:deferred
Tags:
Comment:
Change options
Modified paths:
  • /trunk/extensions/Translate/scripts/groupStatistics.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/scripts/groupStatistics.php
@@ -124,8 +124,8 @@
125125 --speakers : add column for number of speakers (est.). Only valid when
126126 combined with --most.
127127 --nol10n : do not add localised language name if I18ntags is installed.
128 - --continent : add a continent column. Only available when output is not
129 - set or is 'wiki'.
 128+ --continent : add a continent column. Only available when output is
 129+ 'wiki'.
130130
131131 END;
132132 STDERR( $msg );
@@ -297,16 +297,16 @@
298298 $out->element( $code );
299299
300300 // Fill language name field
301 - if( ( !isset( $options['output'] ) || $options['output'] == 'wiki' ) &&
302 - !isset( $options['nol10n'] ) && function_exists( 'efI18nTagsInit' ) ) {
 301+ if( ( $options['output'] == 'wiki' &&
 302+ !isset( $options['nol10n'] ) &&
 303+ function_exists( 'efI18nTagsInit' ) ) {
303304 $out->element( "{{#languagename:" . $code . "}}" );
304305 } else {
305306 $out->element( $name );
306307 }
307308
308309 // Fill continent field
309 - if( ( !isset( $options['output'] ) || $options['output'] == 'wiki' ) &&
310 - isset( $options['output'] ) ) {
 310+ if( $options['output'] == 'wiki' && isset( $options['output'] ) ) {
311311 if( $mostSpokenLanguages[$code][4] == 'multiple' ) {
312312 $continent = '';
313313 } else {

Follow-up revisions

RevisionCommit summaryAuthorDate
r57336Syntax error in r57335siebrand18:20, 3 October 2009

Status & tagging log