r57287 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57286‎ | r57287 | r57288 >
Date:11:38, 2 October 2009
Author:werdna
Status:deferred
Tags:
Comment:
Move inline functionality further up the tree in NewMessages, fixes bug where two edit forms would be shown.
Modified paths:
  • /trunk/extensions/LiquidThreads/pages/NewUserMessagesView.php (modified) (history)
  • /trunk/extensions/LiquidThreads/pages/SpecialNewMessages.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/pages/NewUserMessagesView.php
@@ -111,11 +111,6 @@
112112 if ( ! is_array( $this->threads ) ) {
113113 throw new MWException( 'You must use NewUserMessagesView::setThreads() before calling NewUserMessagesView::show().' );
114114 }
115 -
116 - if ( $this->request->getBool( 'lqt_inline' ) ) {
117 - $this->doInlineEditForm();
118 - return false;
119 - }
120115
121116 // Do everything by id, because we can't depend on reference identity; a simple Thread::withId
122117 // can change the cached value and screw up your references.
Index: trunk/extensions/LiquidThreads/pages/SpecialNewMessages.php
@@ -32,6 +32,11 @@
3333
3434 $view = new NewUserMessagesView( $this->output, $article,
3535 $title, $this->user, $this->request );
 36+
 37+ if ( $this->request->getBool( 'lqt_inline' ) ) {
 38+ $view->doInlineEditForm();
 39+ return;
 40+ }
3641
3742 $view->showOnce(); // handles POST etc.
3843

Follow-up revisions

RevisionCommit summaryAuthorDate
r57292Merge r57287.werdna14:56, 2 October 2009

Status & tagging log