r57282 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57281‎ | r57282 | r57283 >
Date:09:44, 2 October 2009
Author:ialex
Status:ok (Comments)
Tags:
Comment:
* (bug 20885) Search box no longer suggests unavailable special pages
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/PrefixSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/PrefixSearch.php
@@ -83,6 +83,9 @@
8484 $keys[$wgContLang->caseFold( $page )] = $page;
8585 }
8686 foreach( $wgContLang->getSpecialPageAliases() as $page => $aliases ) {
 87+ if( !array_key_exists( $page, SpecialPage::$mList ) ) # bug 20885
 88+ continue;
 89+
8790 foreach( $aliases as $alias ) {
8891 $keys[$wgContLang->caseFold( $alias )] = $alias;
8992 }
Index: trunk/phase3/RELEASE-NOTES
@@ -535,6 +535,7 @@
536536 * Password fields built with HTMLForm now still have the type="password" attribute
537537 if $wgHtml5=false.
538538 * (bug 20836) Preload now works for MediaWiki namespace
 539+* (bug 20885) Search box no longer suggests unavailable special pages
539540
540541 == API changes in 1.16 ==
541542

Comments

#Comment by Brion VIBBER (talk | contribs)   18:37, 6 October 2009

This is probably a side effect of shared localization cache. Good catch. :)

Status & tagging log