r57227 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57226‎ | r57227 | r57228 >
Date:15:52, 1 October 2009
Author:werdna
Status:deferred
Tags:
Comment:
Fix infinite loop on deleting subthreads.
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/Thread.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/Thread.php
@@ -249,14 +249,15 @@
250250
251251 $dbw = wfGetDB( DB_MASTER );
252252
253 -// $dbw->delete( 'user_message_state', array( 'ums_thread' => $this->id() ),
254 -// __METHOD__ );
 253+ $dbw->delete( 'user_message_state', array( 'ums_thread' => $this->id() ),
 254+ __METHOD__ );
255255
256256 // Fix reply count.
257257 $t = $this->superthread();
258258 while( $t ) {
259259 $t->decrementReplyCount();
260260 $t->save();
 261+ $t = $t->superthread();
261262 }
262263 }
263264

Follow-up revisions

RevisionCommit summaryAuthorDate
r57228Merge r57227werdna15:54, 1 October 2009
r57229Fix similar infinite loop to that fixed in r57227 in undeletion.werdna16:04, 1 October 2009

Status & tagging log