r57061 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57060‎ | r57061 | r57062 >
Date:17:08, 29 September 2009
Author:aaron
Status:ok
Tags:
Comment:
Fixed reviewLogLine(), which got broken sometime
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -1416,23 +1416,25 @@
14171417 * @param string $action
14181418 * @param object $title
14191419 * @param array $params
 1420+ * @param string $comment
 1421+ * @param string $rv (review links)
14201422 * @return bool true
14211423 */
1422 - public static function reviewLogLine( $type='', $action='', $title=null, $params=array() ) {
 1424+ public static function reviewLogLine( $type, $action, $title=null, $params=array(), &$comment, &$rv ) {
14231425 $actionsValid = array('approve','approve2','approve-a','approve2-a','unapprove','unapprove2');
14241426 # Show link to page with oldid=x
1425 - if( $type == 'review' && in_array($action,$actionsValid) && is_object($title) && isset($params[0]) ) {
 1427+ if( $type == 'review' && is_object($title) && in_array($action,$actionsValid) && isset($params[0]) ) {
14261428 global $wgUser;
14271429 # Load required messages
14281430 wfLoadExtensionMessages( 'FlaggedRevs' );
14291431 # Don't show diff if param missing or rev IDs are the same
14301432 if( !empty($params[1]) && $params[0] != $params[1] ) {
1431 - $r = '(' . $wgUser->getSkin()->makeKnownLinkObj( $title, wfMsgHtml('review-logentry-diff'),
 1433+ $rv = '(' . $wgUser->getSkin()->makeKnownLinkObj( $title, wfMsgHtml('review-logentry-diff'),
14321434 "oldid={$params[1]}&diff={$params[0]}") . ') ';
14331435 } else {
1434 - $r = '(' . wfMsgHtml('review-logentry-diff') . ')';
 1436+ $rv = '(' . wfMsgHtml('review-logentry-diff') . ')';
14351437 }
1436 - $r .= ' (' . $wgUser->getSkin()->makeKnownLinkObj( $title,
 1438+ $rv .= ' (' . $wgUser->getSkin()->makeKnownLinkObj( $title,
14371439 wfMsgHtml('review-logentry-id',$params[0]),
14381440 "oldid={$params[0]}&diff=prev&diffonly=0") . ')';
14391441 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r57062merged r57061: review log fixaaron17:10, 29 September 2009

Status & tagging log