r57058 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57057‎ | r57058 | r57059 >
Date:16:52, 29 September 2009
Author:aaron
Status:ok
Tags:
Comment:
Fixed title prefix handing (bug 20878)
Modified paths:
  • /trunk/extensions/FlaggedRevs/specialpages/OldReviewedPages_body.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/specialpages/UnreviewedPages_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/specialpages/UnreviewedPages_body.php
@@ -29,7 +29,7 @@
3030 $defaultNS = empty($wgFlaggedRevsNamespaces) ? 0 : $wgFlaggedRevsNamespaces[0];
3131 $namespace = $wgRequest->getIntOrNull( 'namespace', $defaultNS );
3232 $category = trim( $wgRequest->getVal( 'category' ) );
33 - $catTitle = Title::newFromText( $category );
 33+ $catTitle = Title::makeTitleSafe( NS_CATEGORY, $category );
3434 $category = is_null($catTitle) ? '' : $catTitle->getText();
3535 $level = $wgRequest->getInt( 'level' );
3636 $hideRedirs = $wgRequest->getBool( 'hideredirs', true );
Index: trunk/extensions/FlaggedRevs/specialpages/OldReviewedPages_body.php
@@ -20,7 +20,7 @@
2121 $this->namespace = $wgRequest->getIntOrNull( 'namespace' );
2222 $this->level = $wgRequest->getInt( 'level', -1 );
2323 $this->category = trim( $wgRequest->getVal( 'category' ) );
24 - $catTitle = Title::newFromText( $this->category );
 24+ $catTitle = Title::makeTitleSafe( NS_CATEGORY, $this->category );
2525 $this->category = is_null($catTitle) ? '' : $catTitle->getText();
2626 $this->size = $wgRequest->getIntOrNull( 'size' );
2727 $this->watched = $wgRequest->getCheck( 'watched' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r57059merged r57058aaron16:55, 29 September 2009

Status & tagging log