r57023 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57022‎ | r57023 | r57024 >
Date:18:36, 28 September 2009
Author:ialex
Status:ok (Comments)
Tags:
Comment:
replaced split() with explode(), the former is deprecated since PHP 5.3
Modified paths:
  • /trunk/phase3/includes/api/ApiParse.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiParse.php
@@ -178,7 +178,7 @@
179179 $result = array();
180180 foreach( $links as $link ) {
181181 $entry = array();
182 - $bits = split( ':', $link, 2 );
 182+ $bits = explode( ':', $link, 2 );
183183 $entry['lang'] = $bits[0];
184184 $this->getResult()->setContent( $entry, $bits[1] );
185185 $result[] = $entry;

Comments

#Comment by Aaron Schulz (talk | contribs)   21:10, 28 September 2009

Haha, there is a split() ?

Status & tagging log