r56817 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r56816‎ | r56817 | r56818 >
Date:14:13, 23 September 2009
Author:btongminh
Status:ok (Comments)
Tags:
Comment:
(bug 20780) Fix in UploadBase::detectScript: should check for '<a href', not '<a'. The question remains on whether detectScript is redundant to IEContentAnalyzer.
Modified paths:
  • /trunk/phase3/includes/upload/UploadBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/upload/UploadBase.php
——@@ -678,7 +678,7 @@
679679 * when served with a generic content-type.
680680 */
681681 $tags = array(
682 - '<a',
 682+ '<a href',
683683 '<body',
684684 '<head',
685685 '<html', #also in safari

Follow-up revisions

RevisionCommit summaryAuthorDate
r56835Merge r56817 from trunk -- (bug 20780) Fix in UploadBase::detectScript: shoul...brion20:43, 23 September 2009

Comments

#Comment by 😂 (talk | contribs)   14:15, 23 September 2009

What if <a> doesn't begin with href?

#Comment by Bryan (talk | contribs)   14:18, 23 September 2009

Then IE doesn't fuck up apparently.

#Comment by Catrope (talk | contribs)   14:18, 23 September 2009

The objective is to emulate IE's broken algorithm, which also overlooks this. See also bug 20780 comment #3 and below.

#Comment by 😂 (talk | contribs)   14:30, 23 September 2009

Ah ok, I hadn't read the bug. I knew I was stupid and used the precense of <a href as the trigger, didn't know it was so stupid as to only work in that order.

#Comment by 😂 (talk | contribs)   14:31, 23 September 2009

I was stupid -> it was stupid

Status & tagging log