r56803 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56802‎ | r56803 | r56804 >
Date:09:49, 23 September 2009
Author:thomasv
Status:ok
Tags:
Comment:
Fixing minor issues discovered after last scap: Vertical align for MSIE. Test the value of editpage->quality. Remove unnecessary div.
Modified paths:
  • /trunk/extensions/ProofreadPage/ProofreadPage.php (modified) (history)
  • /trunk/extensions/ProofreadPage/proofread.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/ProofreadPage.php
@@ -37,7 +37,7 @@
3838 $wgDjvutxt = null;
3939
4040 # Bump the version number every time you change proofread.js
41 -$wgProofreadPageVersion = 23;
 41+$wgProofreadPageVersion = 24;
4242
4343 # Max width of zoomable image
4444 $wgProofreadPageMaxWidth = 2048;
@@ -616,7 +616,7 @@
617617 if( ! in_array( $q, array('0','1','2','3','4') ) ) {
618618 return "";
619619 }
620 - $message = "<div id=\"pagequality\" width=100% class=quality$q><div id=\"pagequality_content\">".wfMsgForContent( "proofreadpage_quality{$q}_message" )."</div></div>";
 620+ $message = "<div id=\"pagequality\" width=100% class=quality$q>".wfMsgForContent( "proofreadpage_quality{$q}_message" )."</div>";
621621 $out = "__NOEDITSECTION__[[Category:".wfMsgForContent( "proofreadpage_quality{$q}_category" )."]]";
622622 return $wgParser->recursiveTagParse( $out . $message);
623623 }
@@ -880,7 +880,7 @@
881881 ? $editpage->unmakesafe( $text )
882882 : $text;
883883
884 - if( $editpage->quality != null ) {
 884+ if( in_array( $editpage->quality , array( "0", "1", "2", "3", "4" ) ) ) {
885885 //format the page
886886 $text = "<noinclude><pagequality level=\"".$editpage->quality."\" user=\"".$editpage->username."\" />"
887887 .$editpage->header."\n\n\n</noinclude>"
Index: trunk/extensions/ProofreadPage/proofread.js
@@ -562,7 +562,7 @@
563563
564564 var t_row = document.createElement("tr");
565565 t_row.setAttribute("valign","top");
566 - cell_left.style.cssText = "width:50%; padding-right:0.5em;";
 566+ cell_left.style.cssText = "width:50%; padding-right:0.5em;vertical-align:top;";
567567 cell_right.setAttribute("rowspan","3");
568568 t_row.appendChild(cell_left);
569569 t_row.appendChild(cell_right);

Status & tagging log