r56760 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r56759‎ \| r56760 \| r56761 >
Date:	16:04, 22 September 2009
Author:	thomasv
Status:	ok (Comments)
Tags:	todo
Comment:	commenting out the part that depends on PdfHandler update
Modified paths:	/trunk/extensions/ProofreadPage/ProofreadPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/ProofreadPage.php
—	—	@@ -1094,7 +1094,7 @@
1095	1095	$image = wfFindFile( $imageTitle );
1096	1096	if ( $image && $image->exists() ) {
1097	1097	$mime = $image->getMimeType();
1098		~~- if( $mime == 'image/vnd.djvu' \|\| $mime == 'application/pdf') {~~
	1098	+ if( $mime == 'image/vnd.djvu' /\|\| $mime == 'application/pdf'/ ) {
1099	1099	$text = $image->handler->getPageText($image, $m[2]);
1100	1100	if ( $text ) {
1101	1101	$text = preg_replace( "/(\\\\n)/", "\n", $text );

Comments

#Comment by Brion VIBBER (talk | contribs) 16:15, 22 September 2009

Per notes on IRC -- would be best to move getPageText to the base handler class so we can just always call it, and unsupporting formats can just return false. Then this ext doesn't need to worry about which formats support text extraction.

The hardcode is ok for now, since we don't have it in the base class yet.

Status & tagging log

01:08, 18 January 2012 Siebrand (talk | contribs) changed the tags for r56760 [removed: wmf-deployment]
17:48, 24 September 2009 Brion VIBBER (talk | contribs) changed the tags for r56760 [added: wmf-deployment]
16:15, 22 September 2009 Brion VIBBER (talk | contribs) changed the tags for r56760 [added: todo]
16:15, 22 September 2009 Brion VIBBER (talk | contribs) changed the status of r56760 [removed: new added: ok]