r56573 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56572‎ | r56573 | r56574 >
Date:23:04, 17 September 2009
Author:mrzman
Status:ok (Comments)
Tags:todo 
Comment:
Fix for r55393, put the padding:0 on the td's rather than the tables
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -760,12 +760,12 @@
761761
762762 table.mw-enhanced-rc {
763763 background: none;
764 - padding:0;
765764 border:0;
766765 border-spacing:0;
767766 }
768767 td.mw-enhanced-rc {
769768 white-space:nowrap;
 769+ padding:0;
770770 vertical-align:top;
771771 font-family:monospace
772772 }
Index: trunk/phase3/includes/ChangesList.php
@@ -852,7 +852,7 @@
853853 $r .= $this->recentChangesFlags( $isnew, false, $unpatrolled, ' ', $bot );
854854
855855 # Timestamp
856 - $r .= '&nbsp;'.$block[0]->timestamp.'&nbsp;</td><td>';
 856+ $r .= '&nbsp;'.$block[0]->timestamp.'&nbsp;</td><td style="padding:0px;">';
857857
858858 # Article link
859859 if( $namehidden ) {
@@ -954,10 +954,10 @@
955955 extract( $rcObj->mAttribs );
956956
957957 #$r .= '<tr><td valign="top">'.$this->spacerArrow();
958 - $r .= '<tr><td style="vertical-align:top;font-family:monospace">';
 958+ $r .= '<tr><td style="vertical-align:top;font-family:monospace; padding:0px;">';
959959 $r .= $this->spacerIndent() . $this->spacerIndent();
960960 $r .= $this->recentChangesFlags( $rc_new, $rc_minor, $rcObj->unpatrolled, '&nbsp;', $rc_bot );
961 - $r .= '&nbsp;</td><td style="vertical-align:top"><span style="font-family:monospace">';
 961+ $r .= '&nbsp;</td><td style="vertical-align:top; padding:0px;"><span style="font-family:monospace">';
962962
963963 $params = $queryParams;
964964
@@ -1099,7 +1099,7 @@
11001100 } else {
11011101 $r .= $this->recentChangesFlags( $rc_type == RC_NEW, $rc_minor, $rcObj->unpatrolled, '&nbsp;', $rc_bot );
11021102 }
1103 - $r .= '&nbsp;'.$rcObj->timestamp.'&nbsp;</td><td>';
 1103+ $r .= '&nbsp;'.$rcObj->timestamp.'&nbsp;</td><td style="padding:0px;">';
11041104 # Article or log link
11051105 if( $rc_log_type ) {
11061106 $logtitle = Title::newFromText( "Log/$rc_log_type", NS_SPECIAL );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r55393Update ChangesList output for enhanced changes to use CSS instead of obsolete...mrzman21:06, 20 August 2009

Comments

#Comment by Mr.Z-man.sock (talk | contribs)   18:31, 21 September 2009

Look at me, I'm commenting while blocked!

#Comment by Brion VIBBER (talk | contribs)   22:50, 29 September 2009

We should probably move these inline styles to some sane CSS; could massively debloat the HTML here. :)

Status & tagging log