r56564 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56563‎ | r56564 | r56565 >
Date:20:20, 17 September 2009
Author:aaron
Status:ok
Tags:
Comment:
bug 20701: fixed strange breakage from r53173
Modified paths:
  • /trunk/phase3/includes/LogPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogPage.php
@@ -219,12 +219,17 @@
220220 self::formatBlockFlags( $params[2], is_null( $skin ) ) : '';
221221 // Page protections
222222 } else if ( $type == 'protect' && count($params) == 3 ) {
 223+ // Restrictions and expiries
 224+ if( $skin ) {
 225+ $details .= htmlspecialchars( " {$params[1]}" );
 226+ } else {
 227+ $details .= " {$params[1]}";
 228+ }
 229+ // Cascading flag...
223230 if( $params[2] ) {
224231 if ( $skin ) {
225 - $details .= htmlspecialchars( " {$params[1]}" ); // restrictions and expiries
226232 $details .= ' ['.wfMsg('protect-summary-cascade').']';
227233 } else {
228 - $details .= " {$params[1]}";
229234 $details .= ' ['.wfMsgForContent('protect-summary-cascade').']';
230235 }
231236 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r56565merged r56564: protection log fixaaron20:22, 17 September 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53173Fix dodgy uses of wfMsgHtml() and related HTML escapingtstarling15:36, 13 July 2009

Status & tagging log