r56544 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56543‎ | r56544 | r56545 >
Date:17:27, 17 September 2009
Author:aaron
Status:ok
Tags:
Comment:
Still show svg links if the png fails to create
Modified paths:
  • /branches/wmf-deployment/extensions/ReaderFeedback/specialpages/RatingHistory_body.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/extensions/ReaderFeedback/specialpages/RatingHistory_body.php
@@ -491,16 +491,15 @@
492492 $svgHandler = new SvgHandler();
493493 wfSuppressWarnings(); // FS notices possible
494494 if( !file_put_contents( $svgPath, $plot->svg ) ) {
495 - throw new MWException( 'Could not write SVG file!' );
496495 wfRestoreWarnings();
497 - return false;
 496+ throw new MWException( 'Could not write SVG file!' );
498497 }
499498 wfRestoreWarnings();
500499 // Rasterize due to IE suckage
501500 $status = $svgHandler->rasterize( $svgPath, $filePath, 1000, 410 );
502501 if( $status !== true ) {
503502 wfDebug( 'Could not rasterize SVG file from '.$filePath.'!' );
504 - return false;
 503+ //return false;
505504 }
506505 return true;
507506 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r56545Gah, meant to commit r56544 here firstaaron17:31, 17 September 2009

Status & tagging log