r56528 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56527‎ | r56528 | r56529 >
Date:15:36, 17 September 2009
Author:aaron
Status:ok
Tags:
Comment:
Fixed bug from r53507 : talk page confused with article page for sync check
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticle.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedArticle.php
@@ -959,6 +959,7 @@
960960 global $wgRequest, $wgUser, $wgFlaggedRevTabs;
961961
962962 $title = $this->parent->getTitle()->getSubjectPage();
 963+ $article = new Article( $title );
963964 $action = $wgRequest->getVal( 'action', 'view' );
964965 $fa = FlaggedArticle::getTitleInstance( $title );
965966 if ( !$fa->isReviewable() || $this->limitedUI() ) {
@@ -971,7 +972,7 @@
972973 return true;
973974 }
974975 wfLoadExtensionMessages( 'FlaggedRevs' );
975 - $synced = FlaggedRevs::stableVersionIsSynced( $srev, $this->parent );
 976+ $synced = FlaggedRevs::stableVersionIsSynced( $srev, $article );
976977 if ( !$skin->mTitle->isTalkPage() && !$synced ) {
977978 if ( isset( $views['edit'] ) ) {
978979 if ( $this->showStableByDefault() ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r56529Merged r56528: sync bug fix for talk pagesaaron15:38, 17 September 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53507Minor performance & formatting tweaksaaron00:54, 20 July 2009

Status & tagging log