r56491 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56490‎ | r56491 | r56492 >
Date:04:16, 17 September 2009
Author:philip
Status:ok
Tags:
Comment:
Follow up on r53041. Fix a __NOCC__ failure caused by myself and I'm stupid to report it on #Wikimedia-tech!
Modified paths:
  • /trunk/phase3/languages/LanguageConverter.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/LanguageConverter.php
@@ -532,6 +532,8 @@
533533 if( $this->mDoContentConvert )
534534 // Bug 19620: should convert a string immediately after a new rule added.
535535 $text .= $this->autoConvert( $marked[0], $plang );
 536+ else
 537+ $text .= $marked[0];
536538
537539 if ( array_key_exists( 1, $marked ) ) {
538540 $crule = new ConverterRule($marked[1], $this);
@@ -546,7 +548,6 @@
547549
548550 // Remove the last delimiter (wasn't real)
549551 $text = substr( $text, 0, -strlen( $this->mMarkup['end'] ) );
550 -
551552 return $text;
552553 }
553554

Follow-up revisions

RevisionCommit summaryAuthorDate
r56520wmf-deployment: Merge r56491 (__NOCC__ blanks parser output) from trunkcatrope14:59, 17 September 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53041(bug 19620) Allow to convert a string immediately after a new rule added.philip11:45, 10 July 2009

Status & tagging log