r56471 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r56470‎ | r56471 | r56472 >
Date:00:56, 17 September 2009
Author:werdna
Status:ok
Tags:
Comment:
Fix bug where checking another user's blocked status (like for contributions) would cause you to be autoblocked if that user was blocked. Regression in r56325
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
——@@ -1118,7 +1118,7 @@
11191119 $this->mBlockreason = $this->mBlock->mReason;
11201120 $this->mHideName = $this->mBlock->mHideName;
11211121 $this->mAllowUsertalk = $this->mBlock->mAllowUsertalk;
1122 - if ( $this->isLoggedIn() ) {
 1122+ if ( $this->isLoggedIn() && $wgUser->getID() == $this->getID() ) {
11231123 $this->spreadBlock();
11241124 }
11251125 } else {

Follow-up revisions

RevisionCommit summaryAuthorDate
r56473Merge autoblock bug fix r56471werdna00:57, 17 September 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56325Fixing User::getBlockedStatus which broke r55918. Function now works for all ...churchofemacs19:34, 14 September 2009

Status & tagging log