r56344 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56343‎ | r56344 | r56345 >
Date:22:06, 14 September 2009
Author:purodha
Status:deferred
Tags:
Comment:
Show the local navigation even if the current page did not yet exist.
Modified paths:
  • /trunk/extensions/Translate/Translate.php (modified) (history)
  • /trunk/extensions/Translate/TranslateEditAddons.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/TranslateEditAddons.php
@@ -12,7 +12,7 @@
1313 class TranslateEditAddons {
1414 const MSG = 'translate-edit-';
1515
16 - static function addNavigation( &$outputpage, &$text ) {
 16+ static function addedNavigation( &$text ) {
1717 global $wgUser, $wgTitle;
1818
1919 if ( !self::isMessageNamespace( $wgTitle ) ) return true;
@@ -119,6 +119,7 @@
120120 static function addTools( $object ) {
121121 if ( !self::isMessageNamespace( $object->mTitle ) ) return true;
122122
 123+ TranslateEditAddons::addedNavigation( $object->editFormTextTop );
123124 $object->editFormTextTop .= self::editBoxes( $object );
124125
125126 return true;
Index: trunk/extensions/Translate/Translate.php
@@ -49,7 +49,6 @@
5050 $wgSpecialPageGroups['PageTranslation'] = 'pagetools';
5151
5252 $wgHooks['EditPage::showEditForm:initial'][] = 'TranslateEditAddons::addTools';
53 -$wgHooks['OutputPageBeforeHTML'][] = 'TranslateEditAddons::addNavigation';
5453 $wgHooks['AlternateEdit'][] = 'TranslateEditAddons::intro';
5554 $wgHooks['EditPageBeforeEditButtons'][] = 'TranslateEditAddons::buttonHack';
5655 $wgHooks['EditPage::showEditForm:fields'][] = 'TranslateEditAddons::keepFields';

Follow-up revisions

RevisionCommit summaryAuthorDate
r56348partial revert and fix of r56344purodha23:04, 14 September 2009

Status & tagging log