r56298 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56297‎ | r56298 | r56299 >
Date:12:57, 14 September 2009
Author:catrope
Status:resolved
Tags:
Comment:
(bug 18180) Special:Export ignores limit, dir, offset parameters. Patch by azliq7
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Export.php (modified) (history)

Diff [purge]

Index: trunk/phase3/CREDITS
@@ -58,6 +58,7 @@
5959 == Patch Contributors ==
6060 * Agbad
6161 * Ahmad Sherif
 62+* Azliq7
6263 * Borislav Manolov
6364 * Brad Jorsch
6465 * Brent G
Index: trunk/phase3/includes/Export.php
@@ -207,11 +207,8 @@
208208 $opts = array( 'ORDER BY' => 'page_id ASC' );
209209 $opts['USE INDEX'] = array();
210210 $join = array();
211 - # Full history dumps...
212 - if( $this->history & WikiExporter::FULL ) {
213 - $join['revision'] = array('INNER JOIN','page_id=rev_page');
214211 # Latest revision dumps...
215 - } elseif( $this->history & WikiExporter::CURRENT ) {
 212+ if( $this->history & WikiExporter::CURRENT ) {
216213 if( $this->list_authors && $cond != '' ) { // List authors, if so desired
217214 list($page,$revision) = $this->db->tableNamesN('page','revision');
218215 $this->do_list_authors( $page, $revision, $cond );
@@ -247,6 +244,9 @@
248245 if( !empty( $this->history['limit'] ) ) {
249246 $opts['LIMIT'] = intval( $this->history['limit'] );
250247 }
 248+ # Full history dumps...
 249+ } elseif( $this->history & WikiExporter::FULL ) {
 250+ $join['revision'] = array('INNER JOIN','page_id=rev_page');
251251 # Uknown history specification parameter?
252252 } else {
253253 wfProfileOut( __METHOD__ );
Index: trunk/phase3/RELEASE-NOTES
@@ -498,6 +498,7 @@
499499 * (bug 20624) Installation no longer allows "qqq" as the chosen language
500500 * (bug 20634) The installer-created database user will now have CREATE TABLE
501501 and ALTER TABLE rights so that upgrades will go more smoothly.
 502+* (bug 18180) Special:Export ignores limit, dir, offset parameters
502503
503504 == API changes in 1.16 ==
504505

Follow-up revisions

RevisionCommit summaryAuthorDate
r57083Cleanup for r56298 "(bug 18180) Special:Export ignores limit, dir, offset par...brion21:37, 29 September 2009

Status & tagging log