r55854 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r55853
|
r55854
|
r55855
>
Date:
19:40, 5 September 2009
Author:
ialex
Status:
deferred (
Comments
)
Tags:
todo
Comment:
Fix for
r55810
: oly set $optionsWithArgs if it's not defined, as in the old version; when defined by scripts, it's always set before including commandLine.inc, and thus setting it always to an empty array will break these scripts
Modified paths:
/trunk/phase3/maintenance/commandLine.inc
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/maintenance/commandLine.inc
—
—
@@ -4,8 +4,11 @@
5
5
* Backwards-compatibility wrapper for old-style maintenance scripts
6
6
*/
7
7
require( dirname(__FILE__) . '/Maintenance.php' );
8
-$optionsWithArgs = array();
9
8
9
+if ( !isset( $optionsWithArgs ) ) {
10
+ $optionsWithArgs = array();
11
+}
12
+
10
13
class CommandLineInc extends Maintenance {
11
14
public function __construct() {
12
15
global $optionsWithArgs;
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r55810
* Rewrote commandLine.inc to be a simple wrapper around Maintenance.php...
tstarling
08:02, 4 September 2009
Comments
#
Comment by
Brion VIBBER
(
talk
|
contribs
)
21:03, 8 September 2009
This kinda sucks, but is status quo. Should revisit later.
Status & tagging log
21:03, 8 September 2009
Brion VIBBER
(
talk
|
contribs
)
changed the
tags
for r55854
[
added:
todo]
21:03, 8 September 2009
Brion VIBBER
(
talk
|
contribs
)
changed the
status
of r55854
[
removed:
new
added:
deferred]