r55612 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55611‎ | r55612 | r55613 >
Date:18:56, 26 August 2009
Author:demon
Status:ok (Comments)
Tags:
Comment:
Partial revert of r53664 (bug 14201 Set $wgDBadminuser/$wgDBadminpassword during setup). Gives Brion icky feelings about setting a root password.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/config/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/config/Installer.php
@@ -621,7 +621,6 @@
622622 $conf->RootUser = importPost( "RootUser", "root" );
623623 $conf->RootPW = importPost( "RootPW", "" );
624624 $useRoot = importCheck( 'useroot', false );
625 - $conf->populateadmin = importCheck( 'populateadmin', false );
626625 $conf->LanguageCode = importPost( "LanguageCode", "en" );
627626 ## MySQL specific:
628627 $conf->DBprefix = importPost( "DBprefix" );
@@ -1557,8 +1556,6 @@
15581557 <label class="column">Superuser account:</label>
15591558 <input type="checkbox" name="useroot" id="useroot" <?php if( $useRoot ) { ?>checked="checked" <?php } ?> />
15601559 &nbsp;<label for="useroot">Use superuser account</label>
1561 - <input type="checkbox" name="populateadmin" id="populateadmin" <?php if( $conf->populateadmin ) { ?>checked="checked" <?php } ?> />
1562 - &nbsp;<label for="populateadmin">Set as admin user for maintenance</label>
15631560 </div>
15641561 <div class="config-input"><?php aField( $conf, "RootUser", "Superuser name:", "text" ); ?></div>
15651562 <div class="config-input"><?php aField( $conf, "RootPW", "Superuser password:", "password" ); ?></div>
@@ -1824,11 +1821,6 @@
18251822 # Needs literal string interpolation for the current style path
18261823 $slconf['RightsIcon'] = $conf->RightsIcon;
18271824 }
1828 -
1829 - if( $conf->populateadmin ) {
1830 - $slconf['DBadminuser'] = $conf->RootUser;
1831 - $slconf['DBadminpassword'] = $conf->RootPW;
1832 - }
18331825
18341826 if( $conf->DBtype == 'mysql' ) {
18351827 $dbsettings =
@@ -1933,10 +1925,6 @@
19341926
19351927 {$dbsettings}
19361928
1937 -## Database admin settings, used for maintenance scripts
1938 -\$wgDBadminuser = \"". ($conf->populateadmin ? $slconf['DBadminuser'] : '' )."\";
1939 -\$wgDBadminpassword = \"". ($conf->populateadmin ? $slconf['DBadminpassword'] : '' )."\";
1940 -
19411929 ## Shared memory settings
19421930 \$wgMainCacheType = $cacheType;
19431931 \$wgMemCachedServers = $mcservers;
Index: trunk/phase3/RELEASE-NOTES
@@ -151,7 +151,6 @@
152152 * If config/ directory is not executable, the command to make it executable
153153 now asks the user to cd to the correct directory
154154 * Add experimental new external authentication framework, ExternalAuth
155 -* (bug 14201) Set $wgDBadminuser/$wgDBadminpassword during setup
156155 * (bug 18768) Remove AdminSettings requirements. Maintenance environment
157156 will still load it if it exists, but it's not required for anything
158157 * (bug 19900) The "listgrouprights-key" message is now wrapped in a div with

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52336Merge maintenance-work branch:...demon02:02, 24 June 2009
r53664* (bug 14201) Set $wgDBadminuser/$wgDBadminpassword during setup...demon00:31, 23 July 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   17:29, 27 August 2009

Yay!

Status & tagging log