r55483 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55482‎ | r55483 | r55484 >
Date:18:30, 22 August 2009
Author:raymond
Status:resolved (Comments)
Tags:
Comment:
Merge r55331 from wmf-deployment (which was merged from a live hack)
possibly unnecessary global line in HoneypotIntegration?
Modified paths:
  • /trunk/extensions/HoneypotIntegration/HoneypotIntegration.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/HoneypotIntegration/HoneypotIntegration.class.php
@@ -52,6 +52,7 @@
5353 }
5454
5555 public static function loadHoneypotURLs() {
 56+ global $wgMemc, $wgHoneypotURLSource;
5657 $key = wfMemcKey( 'honeypot-integration-urls' );
5758
5859 global $wgHoneypotURLSource;
Property changes on: trunk/extensions/HoneypotIntegration/HoneypotIntegration.class.php
___________________________________________________________________
Name: svn:mergeinfo
5960 + /branches/wmf-deployment/extensions/HoneypotIntegration/HoneypotIntegration.class.php:55331

Follow-up revisions

RevisionCommit summaryAuthorDate
r55528Cleanup r55483, don't need to declare globals twice.demon15:17, 23 August 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r55331Commit some live hacks:...brion17:22, 19 August 2009

Comments

#Comment by Simetrical (talk | contribs)   03:48, 23 August 2009

This looks wrong. global $wgHoneypotURLSource is duplicated three lines down . . .

#Comment by 😂 (talk | contribs)   15:23, 23 August 2009

Should be fixed with r55528

Status & tagging log