r55447 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55446‎ | r55447 | r55448 >
Date:21:40, 21 August 2009
Author:simetrical
Status:ok
Tags:
Comment:
Don't prefill new account name, and autofocus

It's kind of silly to prefill the name of the account to be created from
cookies . . . presumably that account already exists. :)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/templates/Userlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/templates/Userlogin.php
@@ -157,12 +157,13 @@
158158 <td class="mw-label"><label for='wpName2'><?php $this->msg('yourname') ?></label></td>
159159 <td class="mw-input">
160160 <?php
161 - echo Html::input( 'wpName', $this->data['name'], 'text', array(
 161+ echo Html::input( 'wpName', null, 'text', array(
162162 'class' => 'loginText',
163163 'id' => 'wpName2',
164164 'tabindex' => '1',
165165 'size' => '20',
166 - 'required'
 166+ 'required',
 167+ 'autofocus'
167168 ) ); ?>
168169 </td>
169170 </tr>
Index: trunk/phase3/RELEASE-NOTES
@@ -419,6 +419,8 @@
420420 are now normalized to ordinary spaces in titles; if your wiki has existing
421421 titles with such characters, run cleanupTitles.php and/or cleanupImages.php
422422 * (bug 20296) Fixed an PHP warning in Language::getMagic() in PHP 5.3
 423+* When creating accounts, don't prefill name from current username (which
 424+ presumably is already taken)
423425
424426 == API changes in 1.16 ==
425427

Follow-up revisions

RevisionCommit summaryAuthorDate
r56486partial revert of r55447: breaks url wpName prefillingaaron02:15, 17 September 2009
r56487merged r56486: partial revert of r55447: breaks url wpName prefillingaaron02:17, 17 September 2009

Status & tagging log