r55388 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55387‎ | r55388 | r55389 >
Date:17:34, 20 August 2009
Author:werdna
Status:deferred (Comments)
Tags:
Comment:
Change from nested divs to ul-li style, Trevor's suggestion
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/View.php (modified) (history)
  • /trunk/extensions/LiquidThreads/lqt.css (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/lqt.css
@@ -447,3 +447,13 @@
448448 .lqt-command:hover, .lqt-command:hover * {
449449 text-decoration: none !important;
450450 }
 451+
 452+ul.lqt-thread-toolbar-commands {
 453+ list-style-type: none;
 454+ display: inline-block;
 455+ margin: 0;
 456+}
 457+
 458+ul.lqt-thread-toolbar-commands li {
 459+ display: inline-block;
 460+}
Index: trunk/extensions/LiquidThreads/classes/View.php
@@ -668,7 +668,7 @@
669669
670670 foreach( $this->threadMajorCommands( $thread ) as $key => $cmd ) {
671671 $content = $this->contentForCommand( $cmd );
672 - $headerParts[] = Xml::tags( 'span',
 672+ $headerParts[] = Xml::tags( 'li',
673673 array( 'class' => "lqt-command lqt-command-$key" ),
674674 $content );
675675 }
@@ -683,13 +683,13 @@
684684 $dropDownTrigger = Xml::tags( 'span',
685685 array( 'class' => 'lqt-thread-actions-trigger' ),
686686 $triggerText );
687 - $headerParts[] = Xml::tags( 'div',
 687+ $headerParts[] = Xml::tags( 'li',
688688 array( 'class' => 'lqt-thread-toolbar-menu' ),
689689 $dropDownTrigger . $commandHTML );
690690
691691 $html .= implode( ' ', $headerParts );
692692
693 - $html = Xml::tags( 'div', array( 'class' => 'lqt-thread-toolbar-commands' ), $html );
 693+ $html = Xml::tags( 'ul', array( 'class' => 'lqt-thread-toolbar-commands' ), $html );
694694
695695 $html = Xml::tags( 'div', array( 'class' => 'lqt-toolbar-lhs' ), ' ' ) .
696696 $html .

Comments

#Comment by Simetrical (talk | contribs)   00:11, 21 August 2009

inline-block will not work on ul in IE6, IE7, and Firefox < 3. IE6 and IE7 only support inline-block for elements that are display: inline by default, while Firefox < 3 doesn't support inline-block at all. You could probably use floats instead.

#Comment by Werdna (talk | contribs)   16:35, 25 August 2009

Inline-blocks removed in later revisions

Status & tagging log