r55317 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55316‎ | r55317 | r55318 >
Date:11:32, 19 August 2009
Author:werdna
Status:deferred
Tags:
Comment:
Remove obsolete restriction on changing the title by people without the "move" permission
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/View.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/View.php
@@ -310,18 +310,6 @@
311311 wfMsgExt( 'lqt_invalid_subject', 'parse' ) );
312312 }
313313
314 - if ( $subject && $thread && $subject != $thread->subjectWithoutIncrement() &&
315 - !$this->user->isAllowed( 'move' ) ) {
316 - $e->editFormPageTop .=
317 - Xml::tags( 'div', array( 'class' => 'error' ),
318 - wfMsgExt( 'lqt_subject_change_forbidden', 'parse' ) );
319 - $failed_rename = true;
320 -
321 - // Reset the subject
322 - global $wgRequest;
323 - $wgRequest->setVal( 'lqt_subject_field', $thread->subjectWithoutIncrement() );
324 - }
325 -
326314 if ( (!$valid_subject && $subject) || $failed_rename ) {
327315 // Dirty hack to prevent saving from going ahead
328316 global $wgRequest;
@@ -358,9 +346,6 @@
359347 $subject_label = wfMsg( 'lqt_subject' );
360348
361349 $attr = array( 'tabindex' => 1 );
362 - if ( $thread && !$this->user->isAllowed( 'move' ) ) {
363 - $attr['readonly'] = 'readonly';
364 - }
365350
366351 $e->editFormTextBeforeContent .=
367352 Xml::inputLabel( $subject_label, 'lqt_subject_field', 'lqt_subject_field',

Status & tagging log