r55316 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55315‎ | r55316 | r55317 >
Date:11:31, 19 August 2009
Author:werdna
Status:deferred
Tags:
Comment:
Move display: none to be added in JS, not in HTML, otherwise the form doesn't appear without JS2
Modified paths:
  • /trunk/extensions/LiquidThreads/lqt.js (modified) (history)
  • /trunk/extensions/LiquidThreads/pages/TalkpageView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/pages/TalkpageView.php
@@ -230,8 +230,7 @@
231231
232232 global $wgRequest;
233233 if ( $this->methodApplies( 'talkpage_new_thread' ) ) {
234 - $params = array( 'class' => 'lqt-new-thread lqt-edit-form',
235 - 'style' => 'display: none;');
 234+ $params = array( 'class' => 'lqt-new-thread lqt-edit-form' );
236235 $this->output->addHTML( Xml::openElement( 'div', $params ) );
237236 $this->showNewThreadForm();
238237 $this->output->addHTML( Xml::closeElement( 'div' ) );
Index: trunk/extensions/LiquidThreads/lqt.js
@@ -217,6 +217,8 @@
218218 newThreadLink.click( liquidThreads.handleNewLink );
219219 }
220220
 221+ $j('div.lqt-edit-form').each( function() { this.style.display = 'none'; } );
 222+
221223 // Show quote buttons
222224 liquidThreads.showQuoteButtons();
223225 } );

Status & tagging log