r55274 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r55273‎ | r55274 | r55275 >
Date:21:22, 18 August 2009
Author:simetrical
Status:ok (Comments)
Tags:
Comment:
Remove all usage of projection stylesheets

(bug 18497) We don't actually intend for any of these stylesheets to be
used for projection, so providing projection is incorrect. Opera will
not use screen stylesheets in full-screen mode, but *only* if there's at
least one projection stylesheet present somewhere. If we remove *all*
projection stylesheets, then theoretically it should fall back to screen
stylesheets. I've confirmed that this works fine on my dev wiki with
Opera 9.6.
Modified paths:
  • /trunk/WikiWord/WikiWord/attic/www/dermis/XhtmlDerm.php (modified) (history)
  • /trunk/backup/download-index.html (modified) (history)
  • /trunk/backup/dvd.html (modified) (history)
  • /trunk/debs/squid/debian/errors/remote-loader.html (modified) (history)
  • /trunk/extensions/ConfirmAccount/SpecialConfirmAccount.php (modified) (history)
  • /trunk/extensions/DumpHTML/wm-scripts/index.inc (modified) (history)
  • /trunk/extensions/FCKeditor/css/fckeditor.css (modified) (history)
  • /trunk/extensions/OpenID/SpecialOpenIDConvert.body.php (modified) (history)
  • /trunk/extensions/OpenID/SpecialOpenIDLogin.body.php (modified) (history)
  • /trunk/extensions/Review/Review.php (modified) (history)
  • /trunk/extensions/SemanticCalendar/includes/SC_ParserFunctions.php (modified) (history)
  • /trunk/extensions/SemanticDrilldown/specials/SD_BrowseData.php (modified) (history)
  • /trunk/extensions/SemanticDrilldown/specials/SD_CreateFilter.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_Utils.inc (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_CreateCategory.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_CreateClass.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_CreateForm.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_CreateProperty.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_CreateTemplate.php (modified) (history)
  • /trunk/extensions/SemanticResultFormats/Calendar/SRF_Calendar.php (modified) (history)
  • /trunk/extensions/Tasks/Tasks.php (modified) (history)
  • /trunk/extensions/Wikidata/App.php (modified) (history)
  • /trunk/extensions/Wikidata/util/voctrain/view.php (modified) (history)
  • /trunk/extensions/examples/ErrorPage/dbconn.html (modified) (history)
  • /trunk/extensions/examples/ErrorPage/dberr.html (modified) (history)
  • /trunk/extensions/sampleskin/xhtml_sampleskin.pt (modified) (history)
  • /trunk/extensions/wikiforum/wikiforum.php (modified) (history)
  • /trunk/extensions/wikiwyg/share/MediaWiki/extensions/CreatePage/SpecialCreatePage.php (modified) (history)
  • /trunk/extensions/wikiwyg/share/MediaWiki/extensions/MediaWikiWyg.php (modified) (history)
  • /trunk/extensions/wikiwyg/share/MediaWiki/extensions/WikiwygEditing/WikiwygEditing.php (modified) (history)
  • /trunk/fundcore/themes/monobook/style.css (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/includes/templates/NoLocalSettings.php (modified) (history)
  • /trunk/phase3/includes/templates/PHP4.php (modified) (history)
  • /trunk/tools/planet/gmq/templates/index.html.tmpl (modified) (history)
  • /trunk/wiki2xml/php/mediawiki_converter.php (modified) (history)
  • /trunk/wiki2xml/php/xhtml.xslt (modified) (history)
  • /trunk/yawr/base.html (modified) (history)

Diff [purge]

Index: trunk/fundcore/themes/monobook/style.css
——@@ -10,15 +10,15 @@
1111 */
1212
1313 /**
14 - * Stylesheet for screen/projection. All rules not marked media-specific are
15 - * shared with handheld.css and should be updated in tandem. The rules can't
16 - * be in the same file because old browsers like IE5 won't obey @media rules.
 14+ * Stylesheet for screen. All rules not marked media-specific are shared with
 15+ * handheld.css and should be updated in tandem. The rules can't be in the
 16+ * same file because old browsers like IE5 won't obey @media rules.
1717 *
18 - * Rules that are screen/projection-specific are marked with commented-out
19 - * @media rules and indentation.
 18+ * Rules that are screen-specific are marked with commented-out @media rules
 19+ * and indentation.
2020 */
2121
22 -/* @media screen, projection { */
 22+/* @media screen { */
2323 #column-content {
2424 width: 100%;
2525 float: right;
——@@ -106,7 +106,7 @@
107107 border: none;
108108 vertical-align: middle;
109109 }
110 -/* @media screen, projection { */
 110+/* @media screen { */
111111 p {
112112 margin: .4em 0 .5em 0;
113113 line-height: 1.5em;
——@@ -245,7 +245,7 @@
246246 ** the main content area
247247 */
248248
249 -/* @media screen, projection { */
 249+/* @media screen { */
250250 #siteSub {
251251 display: none;
252252 }
——@@ -752,7 +752,7 @@
753753 ** Logo properties
754754 */
755755
756 -/* @media screen, projection { */
 756+/* @media screen { */
757757 #p-logo {
758758 top: 0;
759759 left: 0;
——@@ -779,7 +779,7 @@
780780 ** the navigation portlet
781781 */
782782
783 -/* @media screen, projection { */
 783+/* @media screen { */
784784 #p-navigation {
785785 position: relative;
786786 z-index: 3;
——@@ -805,7 +805,7 @@
806806 /*
807807 ** Search portlet
808808 */
809 -/* @media screen, projection { */
 809+/* @media screen { */
810810 #p-search {
811811 position: relative;
812812 z-index: 3;
——@@ -833,7 +833,7 @@
834834 /*
835835 ** the personal toolbar
836836 */
837 -/* @media screen, projection { */
 837+/* @media screen { */
838838 #p-personal {
839839 position: absolute;
840840 left: 0;
——@@ -918,7 +918,7 @@
919919 /*
920920 ** the page-related actions- page/talk, edit etc
921921 */
922 -/* @media screen, projection { */
 922+/* @media screen { */
923923 #p-cactions {
924924 position: absolute;
925925 top: 1.3em;
——@@ -1013,7 +1013,7 @@
10141014 /*
10151015 ** the remaining portlets
10161016 */
1017 -/* @media screen, projection { */
 1017+/* @media screen { */
10181018 #p-tbx,
10191019 #p-lang {
10201020 position: relative;
——@@ -1068,7 +1068,7 @@
10691069 background-color: #f0f0f0;
10701070 color: #000;
10711071 }
1072 -/* @media screen, projection { */
 1072+/* @media screen { */
10731073 #preftoc li {
10741074 margin: 1px -2px 1px 2px;
10751075 float: left;
——@@ -1135,7 +1135,7 @@
11361136 .prefsection table, .prefsection legend {
11371137 background-color: #F9F9F9;
11381138 }
1139 -/* @media screen, projection { */
 1139+/* @media screen { */
11401140 .mainLegend {
11411141 display: none;
11421142 }
——@@ -1209,7 +1209,7 @@
12101210 font-weight: bold;
12111211 }
12121212
1213 -/* @media screen, projection { */
 1213+/* @media screen { */
12141214 /*
12151215 ** IE/Mac fixes, hope to find a validating way to move this
12161216 ** to a separate stylesheet. This would work but doesn't validate:
Index: trunk/backup/download-index.html
——@@ -3,7 +3,7 @@
44 <head>
55 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
66 <title>Wikimedia Downloads</title>
7 - <style type="text/css" media="screen,projection">/*<![CDATA[*/
 7+ <style type="text/css" media="screen">/*<![CDATA[*/
88 body {
99 font: x-small sans-serif;
1010 background: #f9f9f9 url(http://en.wikipedia.org/skins-1.5/monobook/headbg.jpg) 0 0 no-repeat;
Index: trunk/backup/dvd.html
——@@ -3,7 +3,7 @@
44 <head>
55 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
66 <title>Wikimedia Downloads</title>
7 - <style type="text/css" media="screen,projection">/*<![CDATA[*/
 7+ <style type="text/css" media="screen">/*<![CDATA[*/
88 body {
99 font: x-small sans-serif;
1010 background: #f9f9f9 url(http://en.wikipedia.org/skins-1.5/monobook/headbg.jpg) 0 0 no-repeat;
Index: trunk/yawr/base.html
——@@ -6,7 +6,7 @@
77 <link rel="shortcut icon" href="-/favicon.ico" />
88 <link rel="copyright" href="http://www.gnu.org/copyleft/fdl.html" />
99 <title>%%TITLE%% - Wikipedia</title>
10 - <style type="text/css" media="screen,projection">/*<![CDATA[*/ @import "-/main.css"; /*]]>*/</style>
 10+ <style type="text/css" media="screen">/*<![CDATA[*/ @import "-/main.css"; /*]]>*/</style>
1111
1212 <link rel="stylesheet" type="text/css" media="print" href="-/commonPrint.css" />
1313 <!--[if lt IE 5.5000]><style type="text/css">@import "-/IE50Fixes.css";</style><![endif]-->
Index: trunk/phase3/includes/templates/NoLocalSettings.php
——@@ -39,7 +39,7 @@
4040 <head>
4141 <title>MediaWiki <?php echo htmlspecialchars( $wgVersion ) ?></title>
4242 <meta http-equiv='Content-Type' content='text/html; charset=utf-8' />
43 - <style type='text/css' media='screen, projection'>
 43+ <style type='text/css' media='screen'>
4444 html, body {
4545 color: #000;
4646 background-color: #fff;
Index: trunk/phase3/includes/templates/PHP4.php
——@@ -31,7 +31,7 @@
3232 <head>
3333 <title>MediaWiki <?php echo htmlspecialchars( $wgVersion ); ?></title>
3434 <meta http-equiv='Content-Type' content='text/html; charset=utf-8' />
35 - <style type='text/css' media='screen, projection'>
 35+ <style type='text/css' media='screen'>
3636 html, body {
3737 color: #000;
3838 background-color: #fff;
Index: trunk/phase3/includes/OutputPage.php
——@@ -1870,14 +1870,8 @@
18711871 */
18721872 public function addStyle( $style, $media='', $condition='', $dir='' ) {
18731873 $options = array();
1874 - // In Opera, fullscreen mode is treated as projection mode, and it causes
1875 - // styles set for screen to not be loaded - thus breaking the page - so
1876 - // we can just append projection to the media attribute when it's screen
1877 - // so the browser is happy and - with no side-effects on other browsers.
1878 - // Also - even though we expect the media type to be lowercase, but here
1879 - // we force it to lowercase to be safe.
1880 - if ( strtolower( $media ) == 'screen' )
1881 - $media .= ',projection';
 1874+ // Even though we expect the media type to be lowercase, but here we
 1875+ // force it to lowercase to be safe.
18821876 if( $media )
18831877 $options['media'] = $media;
18841878 if( $condition )
Index: trunk/WikiWord/WikiWord/attic/www/dermis/XhtmlDerm.php
——@@ -115,7 +115,7 @@
116116
117117 function stylelinkEntry($proc, $args) {
118118 $u = $this->escape($args['entry']);
119 - $media = 'screen,projection,print,emboss,handheld'; //TODO...!!!
 119+ $media = 'screen,print,emboss,handheld'; //TODO...!!!
120120
121121 return '<link rel="stylesheet" type="text/css" media="'.$media.'" href="'.$u.'"/>';
122122 }
——@@ -136,7 +136,7 @@
137137
138138 function styleEntry($proc, $args) {
139139 $code = $args['entry'];
140 - $media = 'screen,projection,print,emboss,handheld'; //TODO...!!!
 140+ $media = 'screen,print,emboss,handheld'; //TODO...!!!
141141
142142 return '<style type="text/css" media="'.$media.'">/*<![CDATA[*/'.$code.'/*]]>*/</style>';
143143 }
——@@ -242,7 +242,7 @@
243243 <?= $this->meta('robots', 'robotspolicy') ?>
244244 <?= $this->meta('keywords', 'keywords') ?>
245245 <?= $this->link('shortcut icon', 'favicon') ?>
246 - <?= $this->stylelink('screen,projection', 'maincss') ?>
 246+ <?= $this->stylelink('screen', 'maincss') ?>
247247 <?= $this->stylelink('print', 'printcss') ?>
248248 <?= $this->stylelink('handheld', 'pdacss') ?>
249249 <?
Index: trunk/extensions/FCKeditor/css/fckeditor.css
——@@ -10,15 +10,15 @@
1111 */
1212
1313 /**
14 - * Stylesheet for screen/projection. All rules not marked media-specific are
15 - * shared with handheld.css and should be updated in tandem. The rules can't
16 - * be in the same file because old browsers like IE5 won't obey @media rules.
 14+ * Stylesheet for screen. All rules not marked media-specific are shared with
 15+ * handheld.css and should be updated in tandem. The rules can't be in the
 16+ * same file because old browsers like IE5 won't obey @media rules.
1717 *
18 - * Rules that are screen/projection-specific are marked with commented-out
19 - * @media rules and indentation.
 18+ * Rules that are screen-specific are marked with commented-out @media rules
 19+ * and indentation.
2020 */
2121
22 -/* @media screen, projection { */
 22+/* @media screen { */
2323 #column-one {
2424 padding-top: 160px;
2525 }
——@@ -84,7 +84,7 @@
8585 border: none;
8686 vertical-align: middle;
8787 }
88 -/* @media screen, projection { */
 88+/* @media screen { */
8989 p {
9090 margin: .4em 0 .5em 5px;
9191 line-height: 1.5em;
——@@ -223,7 +223,7 @@
224224 ** the main content area
225225 */
226226
227 -/* @media screen, projection { */
 227+/* @media screen { */
228228 #siteSub {
229229 display: none;
230230 }
——@@ -730,7 +730,7 @@
731731 ** Logo properties
732732 */
733733
734 -/* @media screen, projection { */
 734+/* @media screen { */
735735 #p-logo {
736736 top: 0;
737737 left: 0;
——@@ -757,7 +757,7 @@
758758 ** the navigation portlet
759759 */
760760
761 -/* @media screen, projection { */
 761+/* @media screen { */
762762 #p-navigation {
763763 position: relative;
764764 z-index: 3;
——@@ -783,7 +783,7 @@
784784 /*
785785 ** Search portlet
786786 */
787 -/* @media screen, projection { */
 787+/* @media screen { */
788788 #p-search {
789789 position: relative;
790790 z-index: 3;
——@@ -811,7 +811,7 @@
812812 /*
813813 ** the personal toolbar
814814 */
815 -/* @media screen, projection { */
 815+/* @media screen { */
816816 #p-personal {
817817 position: absolute;
818818 left: 0;
——@@ -896,7 +896,7 @@
897897 /*
898898 ** the page-related actions- page/talk, edit etc
899899 */
900 -/* @media screen, projection { */
 900+/* @media screen { */
901901 #p-cactions {
902902 position: absolute;
903903 top: 1.3em;
——@@ -991,7 +991,7 @@
992992 /*
993993 ** the remaining portlets
994994 */
995 -/* @media screen, projection { */
 995+/* @media screen { */
996996 #p-tbx,
997997 #p-lang {
998998 position: relative;
——@@ -1046,7 +1046,7 @@
10471047 background-color: #f0f0f0;
10481048 color: #000;
10491049 }
1050 -/* @media screen, projection { */
 1050+/* @media screen { */
10511051 #preftoc li {
10521052 margin: 1px -2px 1px 2px;
10531053 float: left;
——@@ -1113,7 +1113,7 @@
11141114 .prefsection table, .prefsection legend {
11151115 background-color: #F9F9F9;
11161116 }
1117 -/* @media screen, projection { */
 1117+/* @media screen { */
11181118 .mainLegend {
11191119 display: none;
11201120 }
——@@ -1187,7 +1187,7 @@
11881188 font-weight: bold;
11891189 }
11901190
1191 -/* @media screen, projection { */
 1191+/* @media screen { */
11921192 /*
11931193 ** IE/Mac fixes, hope to find a validating way to move this
11941194 ** to a separate stylesheet. This would work but doesn't validate:
Index: trunk/extensions/examples/ErrorPage/dberr.html
——@@ -3,7 +3,7 @@
44 <head>
55 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
66 <title>Database error</title>
7 - <style type="text/css" media="screen, projection">/*<![CDATA[*/
 7+ <style type="text/css" media="screen">/*<![CDATA[*/
88 @import "{{skins}}/common/shared.css?104";
99 @import "{{skins}}/monobook/main.css?104";
1010 /*]]>*/</style>
Index: trunk/extensions/examples/ErrorPage/dbconn.html
——@@ -3,7 +3,7 @@
44 <head>
55 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
66 <title>Wikimedia has some problems with database servers</title>
7 - <style type="text/css" media="screen, projection">/*<![CDATA[*/
 7+ <style type="text/css" media="screen">/*<![CDATA[*/
88 @import "{{skins}}/common/shared.css?104";
99 @import "{{skins}}/monobook/main.css?104";
1010 /*]]>*/</style>
Index: trunk/extensions/sampleskin/xhtml_sampleskin.pt
——@@ -4,7 +4,7 @@
55 <meta http-equiv="Content-Type" content="${mimetype}; charset=${charset}" />
66 ${headlinks}
77 <title tal:content="pagetitle">Exciting xhtml slimfast</title>
8 - <style type="text/css" media="screen,projection">/*<![CDATA[*/ @import "${stylepath}/${skinname}/main.css"; /*]]>*/</style>
 8+ <style type="text/css" media="screen">/*<![CDATA[*/ @import "${stylepath}/${skinname}/main.css"; /*]]>*/</style>
99 <script type="text/javascript" tal:attributes="src jsvarurl"></script>
1010 <script type="text/javascript" src="${stylepath}/wikibits.js"></script>
1111 <style tal:condition="usercss" type="text/css">/*<![CDATA[*/ ${usercss} /*]]>*/</style>
Index: trunk/extensions/wikiwyg/share/MediaWiki/extensions/WikiwygEditing/WikiwygEditing.php
——@@ -54,7 +54,7 @@
5555 $wgWikiwygImagePath = "$wgWikiwygPath/share/MediaWiki/images";
5656 }
5757
58 - $wgOut->addScript("<style type=\"text/css\" media=\"screen,projection\">/*<![CDATA[*/ @import \"$wgWikiwygCssPath/MediaWikiwyg.css\"; /*]]>*/</style>\n");
 58+ $wgOut->addScript("<style type=\"text/css\" media=\"screen\">/*<![CDATA[*/ @import \"$wgWikiwygCssPath/MediaWikiwyg.css\"; /*]]>*/</style>\n");
5959 $wgOut->addScript("<script type=\"text/javascript\" src=\"$wgWikiwygJsPath/extensions/WikiwygEditing/js/editpage.js?$wgStyleVersion\"></script>\n");
6060
6161 if (! isset($wgEnableAjaxLogin) || ($wgEnableAjaxLogin == false)) {
Index: trunk/extensions/wikiwyg/share/MediaWiki/extensions/CreatePage/SpecialCreatePage.php
——@@ -45,7 +45,7 @@
4646 $wgWikiwygImagePath = "$wgWikiwygPath/share/MediaWiki/images";
4747 }
4848
49 - $wgOut->addScript("<style type=\"text/css\" media=\"screen,projection\">/*<![CDATA[*/ @import \"$wgWikiwygCssPath/MediaWikiwyg.css\"; /*]]>*/</style>\n");
 49+ $wgOut->addScript("<style type=\"text/css\" media=\"screen\">/*<![CDATA[*/ @import \"$wgWikiwygCssPath/MediaWikiwyg.css\"; /*]]>*/</style>\n");
5050 /* load main js file when not loaded yet */
5151 if (wfGetDependingOnSkin () == 0) {
5252 if (isset($wgWysiwygEnabled) && ($wgWysiwygEnabled == true)) {
Index: trunk/extensions/wikiwyg/share/MediaWiki/extensions/MediaWikiWyg.php
——@@ -75,7 +75,7 @@
7676 $wgWikiwygImagePath = "$wgWikiwygPath/share/MediaWiki/images";
7777 }
7878
79 - $wgOut->addScript("<style type=\"text/css\" media=\"screen,projection\">/*<![CDATA[*/ @import \"$wgWikiwygCssPath/MediaWikiwyg.css\"; /*]]>*/</style>\n");
 79+ $wgOut->addScript("<style type=\"text/css\" media=\"screen\">/*<![CDATA[*/ @import \"$wgWikiwygCssPath/MediaWikiwyg.css\"; /*]]>*/</style>\n");
8080 if (isset($wgWysiwygEnabled) && ($wgWysiwygEnabled == true)) {
8181 $useWysiwygTrue = 1;
8282 } else {
Index: trunk/extensions/SemanticForms/specials/SF_CreateForm.php
——@@ -211,7 +211,7 @@
212212 $wgOut->addLink( array(
213213 'rel' => 'stylesheet',
214214 'type' => 'text/css',
215 - 'media' => "screen, projection",
 215+ 'media' => "screen",
216216 'href' => $sfgScriptPath . "/skins/SF_main.css"
217217 ));
218218 $wgOut->addHTML($text);
Index: trunk/extensions/SemanticForms/specials/SF_CreateProperty.php
——@@ -154,7 +154,7 @@
155155 $wgOut->addLink( array(
156156 'rel' => 'stylesheet',
157157 'type' => 'text/css',
158 - 'media' => "screen, projection",
 158+ 'media' => "screen",
159159 'href' => $sfgScriptPath . "/skins/SF_main.css"
160160 ));
161161 $wgOut->addScript('<script type="text/javascript">' . $javascript_text . '</script>');
Index: trunk/extensions/SemanticForms/specials/SF_CreateClass.php
——@@ -177,7 +177,7 @@
178178 $wgOut->addLink( array(
179179 'rel' => 'stylesheet',
180180 'type' => 'text/css',
181 - 'media' => "screen, projection",
 181+ 'media' => "screen",
182182 'href' => $sfgScriptPath . "/skins/SF_main.css"
183183 ));
184184 $wgOut->addHTML($text);
Index: trunk/extensions/SemanticForms/specials/SF_CreateTemplate.php
——@@ -184,7 +184,7 @@
185185 $wgOut->addLink( array(
186186 'rel' => 'stylesheet',
187187 'type' => 'text/css',
188 - 'media' => "screen, projection",
 188+ 'media' => "screen",
189189 'href' => $sfgScriptPath . "/skins/SF_main.css"
190190 ));
191191 $wgOut->addHTML($text);
Index: trunk/extensions/SemanticForms/specials/SF_CreateCategory.php
——@@ -140,7 +140,7 @@
141141 $wgOut->addLink( array(
142142 'rel' => 'stylesheet',
143143 'type' => 'text/css',
144 - 'media' => "screen, projection",
 144+ 'media' => "screen",
145145 'href' => $sfgScriptPath . "/skins/SF_main.css"
146146 ));
147147 $wgOut->addHTML($text);
Index: trunk/extensions/SemanticForms/includes/SF_Utils.inc
——@@ -103,31 +103,31 @@
104104 $wgOut->addLink( array(
105105 'rel' => 'stylesheet',
106106 'type' => 'text/css',
107 - 'media' => "screen, projection",
 107+ 'media' => "screen",
108108 'href' => $mainCssUrl
109109 ));
110110 $wgOut->addLink( array(
111111 'rel' => 'stylesheet',
112112 'type' => 'text/css',
113 - 'media' => "screen, projection",
 113+ 'media' => "screen",
114114 'href' => $sfgYUIBase . "autocomplete/assets/skins/sam/autocomplete.css"
115115 ));
116116 $wgOut->addLink( array(
117117 'rel' => 'stylesheet',
118118 'type' => 'text/css',
119 - 'media' => "screen, projection",
 119+ 'media' => "screen",
120120 'href' => $sfgScriptPath . '/skins/SF_yui_autocompletion.css'
121121 ));
122122 $wgOut->addLink( array(
123123 'rel' => 'stylesheet',
124124 'type' => 'text/css',
125 - 'media' => "screen, projection",
 125+ 'media' => "screen",
126126 'href' => $sfgScriptPath . '/skins/floatbox.css'
127127 ));
128128 $wgOut->addLink( array(
129129 'rel' => 'stylesheet',
130130 'type' => 'text/css',
131 - 'media' => "screen, projection",
 131+ 'media' => "screen",
132132 'href' => $smwgScriptPath . '/skins/SMW_custom.css'
133133 ));
134134 $wgOut->addScript('<script type="text/javascript" src="' . $sfgYUIBase . 'yahoo/yahoo-min.js"></script>' . "\n");
Index: trunk/extensions/ConfirmAccount/SpecialConfirmAccount.php
——@@ -156,7 +156,7 @@
157157 $wgOut->addLink( array(
158158 'rel' => 'stylesheet',
159159 'type' => 'text/css',
160 - 'media' => 'screen, projection',
 160+ 'media' => 'screen',
161161 'href' => $wgScriptPath . '/extensions/ConfirmAccount/confirmaccount.css',
162162 ) );
163163 return true;
Index: trunk/extensions/wikiforum/wikiforum.php
——@@ -98,7 +98,7 @@
9999 $wgOut->addLink(array(
100100 'rel' => 'stylesheet',
101101 'type' => 'text/css',
102 - 'media' => 'screen,projection',
 102+ 'media' => 'screen',
103103 'href' => FORUM_CSS
104104 ));
105105
——@@ -213,7 +213,7 @@
214214 $wgOut->addLink(array(
215215 'rel' => 'stylesheet',
216216 'type' => 'text/css',
217 - 'media' => 'screen, projection',
 217+ 'media' => 'screen',
218218 'href' => FORUM_CSS
219219 ));
220220 if(FORUM_USE_JS) {
Index: trunk/extensions/SemanticCalendar/includes/SC_ParserFunctions.php
——@@ -96,7 +96,7 @@
9797 $wgOut->addLink( array(
9898 'rel' => 'stylesheet',
9999 'type' => 'text/css',
100 - 'media' => "screen, projection, print",
 100+ 'media' => "screen, print",
101101 'href' => $scgScriptPath . "/skins/SC_main.css"
102102 ));
103103
Index: trunk/extensions/Review/Review.php
——@@ -79,7 +79,7 @@
8080 $wgOut->addLink(array(
8181 'rel' => 'stylesheet',
8282 'type' => 'text/css',
83 - 'media' => 'screen,projection',
 83+ 'media' => 'screen',
8484 'href' => REVIEW_CSS,
8585 ));
8686
Index: trunk/extensions/Wikidata/App.php
——@@ -133,8 +133,8 @@
134134 $rtl = '';
135135 }
136136
137 - $out->addLink( array( 'rel' => 'stylesheet', 'type' => 'text/css', 'media' => 'screen, projection', 'href' => "$wgScriptPath/extensions/Wikidata/OmegaWiki/suggest$rtl.css" ) );
138 - $out->addLink( array( 'rel' => 'stylesheet', 'type' => 'text/css', 'media' => 'screen, projection', 'href' => "$wgScriptPath/extensions/Wikidata/OmegaWiki/tables$rtl.css" ) );
 137+ $out->addLink( array( 'rel' => 'stylesheet', 'type' => 'text/css', 'media' => 'screen', 'href' => "$wgScriptPath/extensions/Wikidata/OmegaWiki/suggest$rtl.css" ) );
 138+ $out->addLink( array( 'rel' => 'stylesheet', 'type' => 'text/css', 'media' => 'screen', 'href' => "$wgScriptPath/extensions/Wikidata/OmegaWiki/tables$rtl.css" ) );
139139 return true;
140140 }
141141
Index: trunk/extensions/Wikidata/util/voctrain/view.php
——@@ -401,11 +401,11 @@
402402 <head>
403403 <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
404404
405 - <link rel="stylesheet" type="text/css" media="screen, projection" href="../ow/styles.css" />
406 - <link rel="stylesheet" type="text/css" media="screen, projection" href="http://www.omegawiki.org/extensions/Wikidata/OmegaWiki/tables.css" />
 405+ <link rel="stylesheet" type="text/css" media="screen" href="../ow/styles.css" />
 406+ <link rel="stylesheet" type="text/css" media="screen" href="http://www.omegawiki.org/extensions/Wikidata/OmegaWiki/tables.css" />
407407 <link rel="shortcut icon" href="http://www.omegawiki.org/favicon.ico" />
408408 <title>OmegaWiki gateway</title>
409 - <style type="text/css" media="screen,projection">/*<![CDATA[*/ @import "http://www.omegawiki.org/skins/monobook/main.css?55"; /*]]>*/</style>
 409+ <style type="text/css" media="screen">/*<![CDATA[*/ @import "http://www.omegawiki.org/skins/monobook/main.css?55"; /*]]>*/</style>
410410 <link rel="stylesheet" type="text/css" media="print" href="http://www.omegawiki.org/skins/common/commonPrint.css?55" />
411411 <link rel="stylesheet" type="text/css" media="handheld" href="http://www.omegawiki.org/skins/monobook/handheld.css?55" />
412412 <link rel="stylesheet" type="text/css" media="screen" href="css/training.css" />
Index: trunk/extensions/SemanticDrilldown/specials/SD_BrowseData.php
——@@ -922,25 +922,25 @@
923923 $wgOut->addLink( array(
924924 'rel' => 'stylesheet',
925925 'type' => 'text/css',
926 - 'media' => "screen, projection",
 926+ 'media' => "screen",
927927 'href' => $mainCssDir . 'SD_main.css'
928928 ));
929929 $wgOut->addLink( array(
930930 'rel' => 'stylesheet',
931931 'type' => 'text/css',
932 - 'media' => "screen, projection",
 932+ 'media' => "screen",
933933 'href' => $mainCssDir . 'ext-all.css'
934934 ));
935935 $wgOut->addLink( array(
936936 'rel' => 'stylesheet',
937937 'type' => 'text/css',
938 - 'media' => "screen, projection",
 938+ 'media' => "screen",
939939 'href' => $mainCssDir . 'xtheme-gray.css'
940940 ));
941941 $wgOut->addLink( array(
942942 'rel' => 'stylesheet',
943943 'type' => 'text/css',
944 - 'media' => "screen, projection",
 944+ 'media' => "screen",
945945 'href' => $mainCssDir . 'combos.css'
946946 ));
947947 // overwrite style from ext-all.css, to set the correct image for
Index: trunk/extensions/SemanticDrilldown/specials/SD_CreateFilter.php
——@@ -225,7 +225,7 @@
226226 $wgOut->addLink( array(
227227 'rel' => 'stylesheet',
228228 'type' => 'text/css',
229 - 'media' => "screen, projection",
 229+ 'media' => "screen",
230230 'href' => $sdgScriptPath . "/skins/SD_main.css"
231231 ));
232232 $wgOut->addHTML($text);
Index: trunk/extensions/DumpHTML/wm-scripts/index.inc
——@@ -12,7 +12,7 @@
1313 <head>
1414 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
1515 <title>Wikipedia Static HTML Dumps</title>
16 - <style type="text/css" media="screen,projection">/*<![CDATA[*/
 16+ <style type="text/css" media="screen">/*<![CDATA[*/
1717 body {
1818 font: x-small sans-serif;
1919 background: #f9f9f9 url(http://en.wikipedia.org/skins-1.5/monobook/headbg.jpg) 0 0 no-repeat;
Index: trunk/extensions/Tasks/Tasks.php
——@@ -1185,7 +1185,7 @@
11861186 $wgOut->addLink(array(
11871187 'rel' => 'stylesheet',
11881188 'type' => 'text/css',
1189 - 'media' => 'screen,projection',
 1189+ 'media' => 'screen',
11901190 'href' => TASKS_CSS,
11911191 ));
11921192 $wgOut->setSubtitle( wfMsgHTML( 'tasks_title', $title->getPrefixedText() ) );
——@@ -1532,7 +1532,7 @@
15331533 $wgOut->addLink(array(
15341534 'rel' => 'stylesheet',
15351535 'type' => 'text/css',
1536 - 'media' => 'screen,projection',
 1536+ 'media' => 'screen',
15371537 'href' => TASKS_CSS,
15381538 ));
15391539 $this->setHeaders();
Index: trunk/extensions/SemanticResultFormats/Calendar/SRF_Calendar.php
——@@ -154,7 +154,7 @@
155155 $wgOut->addLink( array(
156156 'rel' => 'stylesheet',
157157 'type' => 'text/css',
158 - 'media' => "screen, projection, print",
 158+ 'media' => "screen, print",
159159 'href' => $srfgScriptPath . "/Calendar/skins/SRFC_main.css"
160160 ));
161161 wfLoadExtensionMessages('SemanticResultFormats');
Index: trunk/extensions/OpenID/SpecialOpenIDLogin.body.php
——@@ -100,7 +100,7 @@
101101 $wgOut->addLink( array(
102102 'rel' => 'stylesheet',
103103 'type' => 'text/css',
104 - 'media' => 'screen, projection',
 104+ 'media' => 'screen',
105105 'href' => $oidScriptPath . ( $wgOpenIDShowProviderIcons ? '/skin/openid.css' : '/skin/openid-plain.css' )
106106 ) );
107107
Index: trunk/extensions/OpenID/SpecialOpenIDConvert.body.php
——@@ -99,7 +99,7 @@
100100 $wgOut->addLink( array(
101101 'rel' => 'stylesheet',
102102 'type' => 'text/css',
103 - 'media' => 'screen, projection',
 103+ 'media' => 'screen',
104104 'href' => $oidScriptPath . ( $wgOpenIDShowProviderIcons ? '/skin/openid.css' : '/skin/openid-plain.css' )
105105 ) );
106106
Index: trunk/tools/planet/gmq/templates/index.html.tmpl
——@@ -5,7 +5,7 @@
66 <title>Planet Wikimedia</title>
77 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
88
9 -<style type="text/css" media="screen, projection">/*<![CDATA[*/ @import "http://en.wikinews.org/skins-1.5/monobook/main.css"; /*]]>*/</style>
 9+<style type="text/css" media="screen">/*<![CDATA[*/ @import "http://en.wikinews.org/skins-1.5/monobook/main.css"; /*]]>*/</style>
1010 <link rel="stylesheet" type="text/css" media="print" href="http://en.wikinews.org/skins-1.5/common/commonPrint.css" />
1111 <!--[if lt IE 5.5000]><style type="text/css">@import "http://en.wikinews.org/skins-1.5/monobook/IE50Fixes.css";</style><![endif]-->
1212
Index: trunk/wiki2xml/php/mediawiki_converter.php
——@@ -103,7 +103,7 @@
104104 $ret .= '<html xmlns="http://www.w3.org/1999/xhtml">' ;
105105 else $ret .= '<html>' ;
106106 $ret .= '<head>' ;
107 - #$ret .= '<link rel="stylesheet" type="text/css" media="screen,projection" href="http://de.wikipedia.org/skins-1.5/monobook/main.css" />' ;
 107+ #$ret .= '<link rel="stylesheet" type="text/css" media="screen" href="http://de.wikipedia.org/skins-1.5/monobook/main.css" />' ;
108108 #$ret .= '<link rel="stylesheet" type="text/css" media="print" href="http://en.wikipedia.org/skins-1.5/common/commonPrint.css" />' ;
109109 $ret .= '<link rel="stylesheet" type="text/css" href="href://' ;
110110 $ret .= $params["site_base_url"] . 'index.php?title=MediaWiki:Common.css&amp;action=raw" />' ;
Index: trunk/wiki2xml/php/xhtml.xslt
——@@ -38,7 +38,7 @@
3939 <html>
4040 <head>
4141 <title><xsl:value-of select="@title" /></title>
42 - <style type="text/css" media="screen,projection">@import "http://en.wikipedia.org/w/skins-1.5/monobook/main.css";</style>
 42+ <style type="text/css" media="screen">@import "http://en.wikipedia.org/w/skins-1.5/monobook/main.css";</style>
4343 </head>
4444 <body class="ns-0 ltr">
4545 <div id="globalWrapper">
Index: trunk/debs/squid/debian/errors/remote-loader.html
——@@ -7,7 +7,7 @@
88 <link rel="search" type="application/opensearchdescription+xml" href="https://www.mediawiki.org/w/opensearch_desc.php" title="Wikipedia (English)" />
99 <link rel="copyright" href="http://www.gnu.org/copyleft/fdl.html" />
1010 <title>Leech (computing) - Wikipedia, the free encyclopedia</title>
11 - <style type="text/css" media="screen,projection">/*<![CDATA[*/ @import "/skins-1.5/monobook/main.css?52"; /*]]>*/</style>
 11+ <style type="text/css" media="screen">/*<![CDATA[*/ @import "/skins-1.5/monobook/main.css?52"; /*]]>*/</style>
1212 <link rel="stylesheet" type="text/css" media="print" href="https://www.mediawiki.org/skins-1.5/common/commonPrint.css?52" />
1313 <link rel="stylesheet" type="text/css" media="handheld" href="https://www.mediawiki.org/skins-1.5/monobook/handheld.css?52" />
1414 <!--[if lt IE 5.5000]><style type="text/css">@import "/skins-1.5/monobook/IE50Fixes.css?52";</style><![endif]-->

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54326Added release notes for changes in r54109 - a fix to bug #18497 which caused ...tparscal23:43, 3 August 2009

Comments

#Comment by Simetrical (talk | contribs)   22:26, 20 August 2009

Note that an Opera dev confirmed that this will still break full-screen for Opera < 9. Opera 9 was released in June 2006, so I don't think we need to bother for workarounds for such a minor issue in earlier versions.

#Comment by Brion VIBBER (talk | contribs)   00:11, 9 September 2009

My main worry is that something else will creep in -- maybe in a user-side JS gadget -- and break em all again.

#Comment by Simetrical (talk | contribs)   01:40, 9 September 2009

We can fix that if it happens. It's pretty minor breakage, after all . . . if it proves to be a problem we can re-add the bogus projection media types, but let's give this a try.

Status & tagging log