r55184 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55183‎ | r55184 | r55185 >
Date:14:04, 17 August 2009
Author:churchofemacs
Status:ok (Comments)
Tags:
Comment:
Show summary preview also on diff - useful for editing and takes up almost no space
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1415,7 +1415,7 @@
14161416 $editsummary = "<div class='editOptions'>\n";
14171417 global $wgParser;
14181418 $formattedSummary = wfMsgForContent( 'newsectionsummary', $wgParser->stripSectionName( $this->summary ) );
1419 - $subjectpreview = $summarytext && $this->preview ?
 1419+ $subjectpreview = $summarytext && ( $this->preview || $this->diff ) ?
14201420 "<div class=\"mw-summary-preview\">". wfMsgExt('subject-preview', 'parseinline') . $sk->commentBlock( $formattedSummary, $this->mTitle, true )."</div>\n" : '';
14211421 $summarypreview = '';
14221422 } else {
@@ -1442,7 +1442,7 @@
14431443 . $editsummary . '<br/>';
14441444
14451445 $summarypreview = '';
1446 - if ( $summarytext && $this->preview ) {
 1446+ if ( $summarytext && ( $this->preview || $this->diff ) ) {
14471447 $summarypreview =
14481448 Xml::tags( 'div',
14491449 array( 'class' => 'mw-summary-preview' ),

Comments

#Comment by Church of emacs (talk | contribs)   14:38, 17 August 2009

ialex told me there already is a feature request on bugzilla for that. See bug 12525 for discussion.

Status & tagging log