r54997 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r54996‎ | r54997 | r54998 >
Date:08:12, 14 August 2009
Author:raymond
Status:ok
Tags:
Comment:
Recommit r52524 (ialex) after general revert r54735: '' => null when 'descriptionmsg' is not set in $wgExtensionCredits to match $descriptionMsg's default value in SpecialVersion::formatCredits()
Modified paths:
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialVersion.php
——@@ -207,7 +207,7 @@
208208 isset ( $extension['author'] ) ? $extension['author'] : '',
209209 isset ( $extension['url'] ) ? $extension['url'] : null,
210210 isset ( $extension['description'] ) ? $extension['description'] : '',
211 - isset ( $extension['descriptionmsg'] ) ? $extension['descriptionmsg'] : ''
 211+ isset ( $extension['descriptionmsg'] ) ? $extension['descriptionmsg'] : null
212212 );
213213 }
214214 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52524'' => null when 'descriptionmsg' is not set in $wgExtensionCredits to match $...ialex17:42, 28 June 2009
r54735Revert Special:Version to known-good state as of r52060, without the ten bill...brion20:15, 10 August 2009

Status & tagging log