r52060 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r52059‎ | r52060 | r52061 >
Date:18:05, 17 June 2009
Author:raymond
Status:ok (Comments)
Tags:
Comment:
* Add class=wikitable to some tables on specialpages for better styling consistency
* Remove CSS definitions for these tables as far as possible
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/ImagePage.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialListgrouprights.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialStatistics.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialTags.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)
  • /trunk/phase3/skins/modern/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
——@@ -1419,29 +1419,7 @@
14201420 text-align: center;
14211421 }
14221422
1423 -/** Special:Version */
14241423
1425 -table#sv-ext, table#sv-hooks, table#sv-software {
1426 - margin: 1em;
1427 - padding:0em;
1428 -}
1429 -
1430 -#sv-ext td, #sv-hooks td, #sv-software td,
1431 -#sv-ext th, #sv-hooks th, #sv-software th {
1432 - border: 1px solid #A0A0A0;
1433 - padding: 0 0.15em 0 0.15em;
1434 -}
1435 -#sv-ext th, #sv-hooks th, #sv-software th {
1436 - background-color: #F0F0F0;
1437 - color: black;
1438 - padding: 0 0.15em 0 0.15em;
1439 -}
1440 -tr.sv-space{
1441 - height: 0.8em;
1442 - border:none;
1443 -}
1444 -tr.sv-space td { display: none; }
1445 -
14461424 /*
14471425 Table pager (e.g. Special:Imagelist)
14481426 - remove underlines from the navigation link
Index: trunk/phase3/skins/modern/main.css
——@@ -929,29 +929,6 @@
930930 text-align: center;
931931 }
932932
933 -/** Special:Version */
934 -
935 -table#sv-ext, table#sv-hooks, table#sv-software {
936 - margin: 1em;
937 - padding:0em;
938 -}
939 -
940 -#sv-ext td, #sv-hooks td, #sv-software td,
941 -#sv-ext th, #sv-hooks th, #sv-software th {
942 - border: 1px solid #A0A0A0;
943 - padding: 0 0.15em 0 0.15em;
944 -}
945 -#sv-ext th, #sv-hooks th, #sv-software th {
946 - background-color: #F0F0F0;
947 - color: black;
948 - padding: 0 0.15em 0 0.15em;
949 -}
950 -tr.sv-space{
951 - height: 0.8em;
952 - border:none;
953 -}
954 -tr.sv-space td { display: none; }
955 -
956933 /*
957934 Table pager (e.g. Special:Imagelist)
958935 - remove underlines from the navigation link
Index: trunk/phase3/skins/common/shared.css
——@@ -32,16 +32,9 @@
3333 /**
3434 * File histories
3535 */
36 -table.filehistory {
37 - border:1px solid #ccc;
38 - border-collapse:collapse;
39 -}
40 -
4136 table.filehistory th,
4237 table.filehistory td {
43 - padding: 0 0.2em 0 0.2em;
4438 vertical-align:top;
45 - border:1px solid #ccc;
4639 }
4740 table.filehistory th {
4841 text-align: left;
——@@ -406,30 +399,12 @@
407400 font-weight: bold;
408401 }
409402
410 -/*
411 - * Special:ListGroupRights styling
412 - * Special:Statistics styling
413 - * Special:Tags styling
414 -*/
415 -
416 -table.mw-listgrouprights-table,
417 -table.mw-statistics-table,
418 -table.mw-tags-table {
419 - border: 1px solid #ccc;
420 - border-collapse: collapse;
421 -}
422 -
 403+/* Special:ListGroupRights styling */
423404 table.mw-listgrouprights-table tr {
424405 vertical-align: top;
425406 }
426407
427 -table.mw-listgrouprights-table td, table.mw-listgrouprights-table th,
428 -table.mw-statistics-table td, table.mw-statistics-table th,
429 -table.mw-tags-table td, table.mw-tags-table th {
430 - padding: 0.5em 0.2em 0.5em 0.2em;
431 - border: 1px solid #ccc;
432 -}
433 -
 408+/* Special:Statistics styling */
434409 td.mw-statistics-numbers {
435410 text-align: right;
436411 }
Index: trunk/phase3/includes/ImagePage.php
——@@ -809,7 +809,7 @@
810810 . "<div id=\"mw-imagepage-section-filehistory\">\n"
811811 . $wgOut->parse( wfMsgNoTrans( 'filehist-help' ) )
812812 . $navLinks . "\n"
813 - . Xml::openElement( 'table', array( 'class' => 'filehistory' ) ) . "\n"
 813+ . Xml::openElement( 'table', array( 'class' => 'wikitable filehistory' ) ) . "\n"
814814 . '<tr><td></td>'
815815 . ( $this->current->isLocal() && ($wgUser->isAllowed('delete') || $wgUser->isAllowed('deleterevision') ) ? '<td></td>' : '' )
816816 . '<th>' . wfMsgHtml( 'filehist-datetime' ) . '</th>'
Index: trunk/phase3/includes/DefaultSettings.php
——@@ -1486,7 +1486,7 @@
14871487 * to ensure that client-side caches do not keep obsolete copies of global
14881488 * styles.
14891489 */
1490 -$wgStyleVersion = '225';
 1490+$wgStyleVersion = '226';
14911491
14921492
14931493 # Server-side caching:
Index: trunk/phase3/includes/specials/SpecialStatistics.php
——@@ -56,7 +56,7 @@
5757 $this->doRawOutput();
5858 }
5959
60 - $text = Xml::openElement( 'table', array( 'class' => 'mw-statistics-table' ) );
 60+ $text = Xml::openElement( 'table', array( 'class' => 'wikitable mw-statistics-table' ) );
6161
6262 # Statistic - pages
6363 $text .= $this->getPageStats();
Index: trunk/phase3/includes/specials/SpecialListgrouprights.php
——@@ -33,7 +33,7 @@
3434 $this->outputHeader();
3535
3636 $wgOut->addHTML(
37 - Xml::openElement( 'table', array( 'class' => 'mw-listgrouprights-table' ) ) .
 37+ Xml::openElement( 'table', array( 'class' => 'wikitable mw-listgrouprights-table' ) ) .
3838 '<tr>' .
3939 Xml::element( 'th', null, wfMsg( 'listgrouprights-group' ) ) .
4040 Xml::element( 'th', null, wfMsg( 'listgrouprights-rights' ) ) .
Index: trunk/phase3/includes/specials/SpecialVersion.php
——@@ -102,7 +102,7 @@
103103 wfRunHooks( 'SoftwareInfo', array( &$software ) );
104104
105105 $out = Xml::element( 'h2', array( 'id' => 'mw-version-software' ), wfMsg( 'version-software' ) ) .
106 - Xml::openElement( 'table', array( 'id' => 'sv-software' ) ) .
 106+ Xml::openElement( 'table', array( 'class' => 'wikitable', 'id' => 'sv-software' ) ) .
107107 "<tr>
108108 <th>" . wfMsg( 'version-software-product' ) . "</th>
109109 <th>" . wfMsg( 'version-software-version' ) . "</th>
——@@ -174,7 +174,7 @@
175175 wfRunHooks( 'SpecialVersionExtensionTypes', array( &$this, &$extensionTypes ) );
176176
177177 $out = Xml::element( 'h2', array( 'id' => 'mw-version-ext' ), wfMsg( 'version-extensions' ) ) .
178 - Xml::openElement( 'table', array( 'id' => 'sv-ext' ) );
 178+ Xml::openElement( 'table', array( 'class' => 'wikitable', 'id' => 'sv-ext' ) );
179179
180180 foreach ( $extensionTypes as $type => $text ) {
181181 if ( isset ( $wgExtensionCredits[$type] ) && count ( $wgExtensionCredits[$type] ) ) {
——@@ -291,7 +291,7 @@
292292 ksort( $myWgHooks );
293293
294294 $ret = Xml::element( 'h2', array( 'id' => 'mw-version-hooks' ), wfMsg( 'version-hooks' ) ) .
295 - Xml::openElement( 'table', array( 'id' => 'sv-hooks' ) ) .
 295+ Xml::openElement( 'table', array( 'class' => 'wikitable', 'id' => 'sv-hooks' ) ) .
296296 "<tr>
297297 <th>" . wfMsg( 'version-hook-name' ) . "</th>
298298 <th>" . wfMsg( 'version-hook-subscribedby' ) . "</th>
Index: trunk/phase3/includes/specials/SpecialTags.php
——@@ -36,7 +36,7 @@
3737 $html .= $this->doTagRow( $tag, 0 );
3838 }
3939
40 - $wgOut->addHTML( Xml::tags( 'table', array( 'class' => 'mw-tags-table' ), $html ) );
 40+ $wgOut->addHTML( Xml::tags( 'table', array( 'class' => 'wikitable mw-tags-table' ), $html ) );
4141 }
4242
4343 function doTagRow( $tag, $hitcount ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r54735Revert Special:Version to known-good state as of r52060, without the ten bill...brion20:15, 10 August 2009

Comments

#Comment by Jidanni (talk | contribs)   20:12, 18 June 2009

But hey! Please see/integrate Attachment 6204 for Bug 18829.

Status & tagging log