r54829 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54828‎ | r54829 | r54830 >
Date:00:13, 12 August 2009
Author:demon
Status:ok (Comments)
Tags:
Comment:
PHP5 has been out for years now.
Modified paths:
  • /trunk/phase3/install-utils.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/install-utils.inc
@@ -56,9 +56,9 @@
5757 * Known fixed with PHP 5.2.9 + libxml2-2.7.3
5858 */
5959 class PhpXmlBugTester {
60 - var $parsedData = '';
61 - var $ok = false;
62 - function __construct() {
 60+ private $parsedData = '';
 61+ public $ok = false;
 62+ public function __construct() {
6363 $charData = '<b>c</b>';
6464 $xml = '<a>' . htmlspecialchars( $charData ) . '</a>';
6565
@@ -67,7 +67,7 @@
6868 $parsedOk = xml_parse($parser, $xml, true);
6969 $this->ok = $parsedOk && ($this->parsedData == $charData);
7070 }
71 - function chardata($parser, $data) {
 71+ public function chardata($parser, $data) {
7272 $this->parsedData .= $data;
7373 }
7474 }

Comments

#Comment by Brion VIBBER (talk | contribs)   00:49, 19 August 2009

Nothing in this commit does anything useful; it just clutters up the source.

Status & tagging log