r54654 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54653‎ | r54654 | r54655 >
Date:12:55, 9 August 2009
Author:demon
Status:ok (Comments)
Tags:
Comment:
Make $site and $lang global, just to be safe. Call finalSetup() in loadWikimediaSettings()
Modified paths:
  • /trunk/phase3/maintenance/Maintenance.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/Maintenance.php
@@ -572,7 +572,7 @@
573573 * Do setup specific to WMF
574574 */
575575 public function loadWikimediaSettings() {
576 - global $IP, $wgNoDBParam, $wgUseNormalUser, $wgConf;
 576+ global $IP, $wgNoDBParam, $wgUseNormalUser, $wgConf, $site, $lang;
577577
578578 if ( empty( $wgNoDBParam ) ) {
579579 # Check if we were passed a db name
@@ -616,6 +616,8 @@
617617 if ( $lang == 'test' && $site == 'wikipedia' ) {
618618 define( 'TESTWIKI', 1 );
619619 }
 620+
 621+ $this->finalSetup();
620622 }
621623
622624 /**

Comments

#Comment by Brion VIBBER (talk | contribs)   20:21, 10 August 2009

awful hack :)

Status & tagging log