r54646 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54645‎ | r54646 | r54647 >
Date:09:52, 9 August 2009
Author:catrope
Status:deferred
Tags:
Comment:
EditToolbar: Allow user/site JS, which is loaded before editToolbarConfiguration is declared, to customize it with $(document).bind('toolbarConfig', callback); and bump style versions for r54642
Modified paths:
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -51,14 +51,14 @@
5252 array( 'src' => 'js/plugins/jquery.cookie.js', 'version' => 3 ),
5353 array( 'src' => 'js/plugins/jquery.textSelection.js', 'version' => 3 ),
5454 array( 'src' => 'js/plugins/jquery.wikiEditor.js', 'version' => 3 ),
55 - array( 'src' => 'js/plugins/jquery.wikiEditor.toolbar.js', 'version' => 3 ),
 55+ array( 'src' => 'js/plugins/jquery.wikiEditor.toolbar.js', 'version' => 4 ),
5656 array( 'src' => 'js/plugins/jquery.wikiEditor.toc.js', 'version' => 3 ),
5757 ),
5858 'combined' => array(
59 - array( 'src' => 'js/plugins.combined.js', 'version' => 3 ),
 59+ array( 'src' => 'js/plugins.combined.js', 'version' => 4 ),
6060 ),
6161 'minified' => array(
62 - array( 'src' => 'js/plugins.combined.min.js', 'version' => 3 ),
 62+ array( 'src' => 'js/plugins.combined.min.js', 'version' => 4 ),
6363 ),
6464 ),
6565 );
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js
@@ -1,6 +1,8 @@
22 /* JavaScript for EditToolbar extension */
33
44 js2AddOnloadHook( function() {
 5+ // Allow user/site JS to customize editToolbarConfiguration
 6+ $j( document ).trigger( 'toolbarConfig' );
57 $j( 'textarea#wpTextbox1' ).wikiEditor(
68 { 'toolbar': editToolbarConfiguration }
79 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r54711EditToolbar: Followup to r54646: add config var as parameter to event handlercatrope11:19, 10 August 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54642EditToolbar: Improve toolbar loading experience by adding tabs immediately in...catrope21:29, 8 August 2009

Status & tagging log