r54592 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r54591‎ | r54592 | r54593 >
Date:17:26, 7 August 2009
Author:tparscal
Status:ok
Tags:
Comment:
Made some changes which don't affect normal users, but content loaded into Apple Dictionary should be somewhat more usable.
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
——@@ -539,33 +539,33 @@
540540 <?php $this->renderPortals( $this->data['sidebar'] ); ?>
541541 </div>
542542 <!-- /panel -->
543 - <!-- foot -->
544 - <div id="foot">
 543+ <!-- logo -->
 544+ <div id="p-logo"><a style="background-image: url(<?php $this->text( 'logopath' ) ?>);" href="<?php echo htmlspecialchars( $this->data['nav_urls']['mainpage']['href'] ) ?>" <?php echo $this->skin->tooltipAndAccesskey( 'p-logo' ) ?>></a></div>
 545+ <!-- /logo -->
 546+ <!-- footer -->
 547+ <div id="footer">
545548 <?php foreach( $validFooterLinks as $category => $links ): ?>
546549 <?php if ( count( $links ) > 0 ): ?>
547 - <ul id="foot-<?php echo $category ?>">
 550+ <ul id="footer-<?php echo $category ?>">
548551 <?php foreach( $links as $link ): ?>
549552 <?php if( isset( $this->data[$link] ) && $this->data[$link] ): ?>
550 - <li id="foot-<?php echo $category ?>-<?php echo $link ?>"><?php $this->html( $link ) ?></li>
 553+ <li id="footer-<?php echo $category ?>-<?php echo $link ?>"><?php $this->html( $link ) ?></li>
551554 <?php endif; ?>
552555 <?php endforeach; ?>
553556 </ul>
554557 <?php endif; ?>
555558 <?php endforeach; ?>
556 - <ul id="foot-icons" class="noprint">
 559+ <ul id="footer-icons" class="noprint">
557560 <?php if ( $this->data['poweredbyico'] ): ?>
558 - <li id="foot-icon-poweredby"><?php $this->html( 'poweredbyico' ) ?></li>
 561+ <li id="footer-icon-poweredby"><?php $this->html( 'poweredbyico' ) ?></li>
559562 <?php endif; ?>
560563 <?php if ( $this->data['copyrightico'] ): ?>
561 - <li id="foot-icon-copyright"><?php $this->html( 'copyrightico' ) ?></li>
 564+ <li id="footer-icon-copyright"><?php $this->html( 'copyrightico' ) ?></li>
562565 <?php endif; ?>
563566 </ul>
564567 <div style="clear:both"></div>
565568 </div>
566 - <!-- /foot -->
567 - <!-- logo -->
568 - <div id="p-logo"><a style="background-image: url(<?php $this->text( 'logopath' ) ?>);" href="<?php echo htmlspecialchars( $this->data['nav_urls']['mainpage']['href'] ) ?>" <?php echo $this->skin->tooltipAndAccesskey( 'p-logo' ) ?>></a></div>
569 - <!-- /logo -->
 569+ <!-- /footer -->
570570 <!-- fixalpha -->
571571 <script type="<?php $this->text('jsmimetype') ?>"> if ( window.isMSIE55 ) fixalpha(); </script>
572572 <!-- /fixalpha -->
Index: trunk/phase3/skins/vector/main-ltr.css
——@@ -379,8 +379,8 @@
380380 #panel div.portal div.body ul li a:visited {
381381 color: #0b0080;
382382 }
383 -/* Foot */
384 -#foot {
 383+/* Footer */
 384+#footer {
385385 margin-left: 12em;
386386 margin-top: 0;
387387 padding: 0.75em;
——@@ -388,12 +388,14 @@
389389 background-position: top left;
390390 background-repeat: repeat-x;
391391 }
392 -#foot ul {
 392+#footer ul {
393393 list-style: none;
 394+ list-style-image: none;
 395+ list-style-type: none;
394396 margin: 0;
395397 padding: 0;
396398 }
397 -#foot ul li {
 399+#footer ul li {
398400 margin: 0;
399401 padding: 0;
400402 padding-top: 0.5em;
——@@ -401,21 +403,21 @@
402404 color: #333333;
403405 font-size: 0.9em;
404406 }
405 -#foot #foot-icons {
 407+#footer #footer-icons {
406408 float: right;
407409 }
408 -#foot #foot-places {
 410+#footer #footer-places {
409411 float: left;
410412 }
411 -#foot #foot-info li {
 413+#footer #footer-info li {
412414 line-height: 1.4em;
413415 }
414 -#foot #foot-icons li {
 416+#footer #footer-icons li {
415417 float: left;
416418 margin-left: 0.5em;
417419 line-height: 2em;
418420 }
419 -#foot #foot-places li {
 421+#footer #footer-places li {
420422 float: left;
421423 margin-right: 1em;
422424 line-height: 2em;
Index: trunk/phase3/skins/vector/main-rtl.css
——@@ -379,8 +379,8 @@
380380 #panel div.portal div.body ul li a:visited {
381381 color: #0b0080;
382382 }
383 -/* Foot */
384 -#foot {
 383+/* Footer */
 384+#footer {
385385 margin-right: 12em;
386386 margin-top: 0;
387387 padding: 0.75em;
——@@ -388,12 +388,14 @@
389389 background-position: top right;
390390 background-repeat: repeat-x;
391391 }
392 -#foot ul {
 392+#footer ul {
393393 list-style: none;
 394+ list-style-image: none;
 395+ list-style-type: none;
394396 margin: 0;
395397 padding: 0;
396398 }
397 -#foot ul li {
 399+#footer ul li {
398400 margin: 0;
399401 padding: 0;
400402 padding-top: 0.5em;
——@@ -401,21 +403,21 @@
402404 color: #333333;
403405 font-size: 0.9em;
404406 }
405 -#foot #foot-icons {
 407+#footer #footer-icons {
406408 float: left;
407409 }
408 -#foot #foot-places {
 410+#footer #footer-places {
409411 float: right;
410412 }
411 -#foot #foot-info li {
 413+#footer #footer-info li {
412414 line-height: 1.4em;
413415 }
414 -#foot #foot-icons li {
 416+#footer #footer-icons li {
415417 float: right;
416418 margin-right: 0.5em;
417419 line-height: 2em;
418420 }
419 -#foot #foot-places li {
 421+#footer #footer-places li {
420422 float: right;
421423 margin-left: 1em;
422424 line-height: 2em;

Follow-up revisions

RevisionCommit summaryAuthorDate
r54596Merge r54592 Vector tweaks for compat with Apple Dictionary app's screen-scraperbrion18:43, 7 August 2009

Status & tagging log