r54545 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54544‎ | r54545 | r54546 >
Date:22:35, 6 August 2009
Author:demon
Status:ok (Comments)
Tags:
Comment:
Followup r54516, remove globals entirely.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialStatistics.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
@@ -4155,16 +4155,3 @@
41564156 * The minimum amount of memory that MediaWiki "needs"; MediaWiki will try to raise PHP's memory limit if it's below this amount.
41574157 */
41584158 $wgMemoryLimit = "50M";
4159 -
4160 -/**
4161 - * Allow extensions to add Statistics at the end of Special:Statistics.
4162 - */
4163 -$wgAllowStatsOther = true;
4164 -
4165 -/**
4166 - * Statistics which add at the end of Special:Statistics.
4167 - * Use: $wgStatsOther['<name of statistic>'] = <value>;
4168 - * Example: $wgStatsOther['Time since 01.01.1970'] = time();
4169 - */
4170 -$wgStatsOther = array();
4171 -
Index: trunk/phase3/includes/specials/SpecialStatistics.php
@@ -266,7 +266,7 @@
267267 }
268268
269269 private function getOtherStats( $stats ) {
270 - global $wgLang, $wgAllowStatsOther, $wgStatsOther;
 270+ global $wgLang;
271271
272272 $return = Xml::openElement( 'tr' ) .
273273 Xml::tags( 'th', array( 'colspan' => '2' ), wfMsgExt( 'statistics-header-hooks', array( 'parseinline' ) ) ) .

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54516(r54511) Replace global array with hookjan13:40, 6 August 2009

Comments

#Comment by Jan Luca (talk | contribs)   07:09, 7 August 2009

Thank you!

Status & tagging log