r54463 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54462‎ | r54463 | r54464 >
Date:17:27, 5 August 2009
Author:tparscal
Status:resolved (Comments)
Tags:
Comment:
Switched to img tags from input buttons since the form was getting confused which button to execute when the user pressed enter. Fixes bug #19776.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/css/wikiEditor.toolbar.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/css/wikiEditor.toolbar.css
@@ -148,7 +148,7 @@
149149 margin-left: 8px;
150150 margin-right: 5px;
151151 }
152 -.wikiEditor-ui .wikiEditor-ui-toolbar .group input.tool {
 152+.wikiEditor-ui .wikiEditor-ui-toolbar .group img.tool {
153153 float: left;
154154 border: 0px;
155155 height: 22px;
@@ -157,7 +157,7 @@
158158 cursor: pointer;
159159 }
160160 /* IGNORED BY IE6 */
161 -body.rtl .wikiEditor-ui .wikiEditor-ui-toolbar .group > input.tool {
 161+body.rtl .wikiEditor-ui .wikiEditor-ui-toolbar .group > img.tool {
162162 float: right;
163163 }
164164 .wikiEditor-ui .wikiEditor-ui-toolbar .group select {
Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js
@@ -151,8 +151,7 @@
152152 var label = $.wikiEditor.modules.toolbar.fn.autoMsg( tool, 'label' );
153153 switch ( tool.type ) {
154154 case 'button':
155 - $button = $( '<input />' ).attr( {
156 - 'type': 'image',
 155+ $button = $( '<img />' ).attr( {
157156 'src': $.wikiEditor.modules.toolbar.imgPath + tool.icon,
158157 'alt': label,
159158 'title': label,

Comments

#Comment by Brion VIBBER (talk | contribs)   17:40, 5 August 2009

combined & minified versions not updated

#Comment by Trevor Parscal (WMF) (talk | contribs)   18:54, 5 August 2009

Fixed in r54464.

#Comment by Werdna (talk | contribs)   16:56, 27 August 2009

Taking this as resolved.

Status & tagging log