r54365 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54364‎ | r54365 | r54366 >
Date:15:28, 4 August 2009
Author:tparscal
Status:deferred
Tags:
Comment:
Removed level 1 heading from toolbar (solving bug #20065). Removed console debugging statement which - when firebug isn't open - caused a javascript error. Rebuilt combined and minified versions of plugins.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.min.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js
@@ -132,17 +132,6 @@
133133 labelMsg: 'edittoolbar-tool-heading',
134134 type: 'select',
135135 list: {
136 - 'heading-1' : {
137 - labelMsg: 'edittoolbar-tool-heading-1',
138 - action: {
139 - type: 'encapsulate',
140 - options: {
141 - pre: "=",
142 - periMsg: 'edittoolbar-tool-heading-example',
143 - post: "="
144 - }
145 - }
146 - },
147136 'heading-2' : {
148137 labelMsg: 'edittoolbar-tool-heading-2',
149138 action: {
Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.js
@@ -94,7 +94,6 @@
9595 var useTool = function() {
9696 var tool = $(this).data( 'tool' );
9797 if ( 'type' in tool ) {
98 - console.log( tool.type );
9998 switch ( tool.type ) {
10099 case 'button':
101100 case 'link':
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.js
@@ -612,7 +612,6 @@
613613 var useTool = function() {
614614 var tool = $(this).data( 'tool' );
615615 if ( 'type' in tool ) {
616 - console.log( tool.type );
617616 switch ( tool.type ) {
618617 case 'button':
619618 case 'link':
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.min.js
@@ -44,7 +44,7 @@
4545 return $(this).data('context',context);}
4646 return $(this);}
4747 context={'$textarea':$(this),'modules':{},'data':{}};$(this).wrap($('<div></div>').addClass('wikiEditor-ui')).wrap($('<div></div>').addClass('wikiEditor-ui-bottom')).wrap($('<div></div>').addClass('wikiEditor-ui-text'));context.$ui=$(this).parent().parent().parent();context.$ui.prepend($('<div></div>').addClass('wikiEditor-ui-top'));context.modules.toolbar={performAction:function(action){switch(action.type){case'encapsulate':var parts={'pre':'','peri':'','post':''};for(part in parts){if(part+'Msg'in action.options){parts[part]=gM(action.options[part+'Msg'],(action.options[part]||null));}else{parts[part]=(action.options[part]||'')}}
48 -context.$textarea.encapsulateSelection(parts.pre,parts.peri,parts.post);break;default:break;}},addSection:function($section,section,sectionId){var useTool=function(){var tool=$(this).data('tool');if('type'in tool){console.log(tool.type);switch(tool.type){case'button':case'link':if('action'in tool){context.modules.toolbar.performAction(tool.action);}
 48+context.$textarea.encapsulateSelection(parts.pre,parts.peri,parts.post);break;default:break;}},addSection:function($section,section,sectionId){var useTool=function(){var tool=$(this).data('tool');if('type'in tool){switch(tool.type){case'button':case'link':if('action'in tool){context.modules.toolbar.performAction(tool.action);}
4949 break;case'select':if('list'in tool&&$(this).val()in tool.list){context.modules.toolbar.performAction(tool.list[$(this).val()].action);}
5050 $(this).find(":selected").attr('selected',false);$(this).find(":first").attr('selected',true);break;}}
5151 return false;}

Status & tagging log