r54366 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54365‎ | r54366 | r54367 >
Date:16:21, 4 August 2009
Author:raymond
Status:ok
Tags:
Comment:
Revert r54363: This kind of styling is really not needed for consisteny with other error messaes
As Nikerabbit pointed out on CodeReview the surrounding p should go into code.
The messages can than be surrounded by <p class="error"></p>
Modified paths:
  • /trunk/extensions/ExternalData/ExternalData.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ExternalData/ExternalData.i18n.php
@@ -9,20 +9,19 @@
1010
1111 /** English
1212 * @author Yaron Koren
13 - * @author Purodha
1413 */
1514 $messages['en'] = array(
1615 // user messages
1716 'getdata' => 'Get data',
1817 'externaldata-desc' => 'Allows for retrieving data in CSV, JSON and XML formats from both external URLs and local wiki pages',
1918 'externaldata-ldap-unable-to-connect' => 'Unable to connect to $1\n',
20 - 'externaldata-json-decode-not-supported' => '<span style="text-transform: uppercase">Error:</span> json_decode() is not supported in this version of PHP',
 19+ 'externaldata-json-decode-not-supported' => 'Error: json_decode() is not supported in this version of PHP',
2120 'externaldata-xml-error' => 'XML error: $1 at line $2',
22 - 'externaldata-db-incomplete-information' => '<p><span style="text-transform: uppercase">Error:</span> Incomplete information for this server ID.</p>\n',
 21+ 'externaldata-db-incomplete-information' => '<p>Error: Incomplete information for this server ID.</p>\n',
2322 'externaldata-db-could-not-get-url' => 'Could not get URL after $1 tries.\n\n',
24 - 'externaldata-db-unknown-type' => '<p><span style="text-transform: uppercase">Error:</span> Unknown database type.</p>\n',
25 - 'externaldata-db-could-not-connect' => '<p><span style="text-transform: uppercase">Error:</span> Could not connect to database.</p>\n',
26 - 'externaldata-db-no-return-values' => '<p><span style="text-transform: uppercase">Error:</span> No return values specified.</p>\n',
 23+ 'externaldata-db-unknown-type' => '<p>Error: Unknown database type.</p>\n',
 24+ 'externaldata-db-could-not-connect' => '<p>Error: Could not connect to database.</p>\n',
 25+ 'externaldata-db-no-return-values' => '<p>Error: No return values specified.</p>\n',
2726 'externaldata-db-invalid-query' => 'Invalid query.',
2827 );
2928

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54363Consistent spelling. All-caps rendering vis CSS.purodha14:50, 4 August 2009

Status & tagging log